[Shape inference] Always set the output of Shape to be rank-1 #3394
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Even when the input shape is unavailable, the output of Shape will always be a rank-1 vector. Signed-off-by: Derek Murray <demurra@microsoft.com>
mrry
changed the title
|
Thanks! May help to apply same fix to older version of Shape (in old.cc) also. |
|
|
Signed-off-by: Derek Murray <demurra@microsoft.com>
|
Thanks @gramalingam... good idea, done! |
gramalingam
approved these changes
Apr 2, 2021
postrational
approved these changes
Apr 3, 2021
jcwchen
pushed a commit
to jcwchen/onnx
that referenced
this pull request
Apr 5, 2021
) * [Shape inference] Always set the output of Shape to have rank-1. Even when the input shape is unavailable, the output of Shape will always be a rank-1 vector. Signed-off-by: Derek Murray <demurra@microsoft.com> * Apply fix to Shape-1 as well. Signed-off-by: Derek Murray <demurra@microsoft.com> Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com>
jcwchen
added a commit
that referenced
this pull request
Apr 5, 2021
* [Shape inference] Always set the output of Shape to be rank-1 (#3394) * [Shape inference] Always set the output of Shape to have rank-1. Even when the input shape is unavailable, the output of Shape will always be a rank-1 vector. Signed-off-by: Derek Murray <demurra@microsoft.com> * Apply fix to Shape-1 as well. Signed-off-by: Derek Murray <demurra@microsoft.com> Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com> * Implement NonZero shape inference (#3364) * Implement NonZero shape inference Signed-off-by: impactaky <impactaky@users.noreply.github.com> * Add shape inference code to NonZero-9 Signed-off-by: impactaky <impactaky@users.noreply.github.com> * Add type annotation Signed-off-by: impactaky <impactaky@users.noreply.github.com> Co-authored-by: impactaky <impactaky@users.noreply.github.com> Co-authored-by: Ashwini Khade <askhade@microsoft.com> Co-authored-by: Michał Karzyński <4430709+postrational@users.noreply.github.com> Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com> * bump version number Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com> Co-authored-by: Derek Murray <derek.murray@gmail.com> Co-authored-by: impactaky <37619203+impactaky@users.noreply.github.com> Co-authored-by: impactaky <impactaky@users.noreply.github.com> Co-authored-by: Ashwini Khade <askhade@microsoft.com> Co-authored-by: Michał Karzyński <4430709+postrational@users.noreply.github.com>
jcwchen
added a commit
to jcwchen/onnx
that referenced
this pull request
Jun 30, 2021
…onnx#3394)" This reverts commit de46066.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Even when the input shape is unavailable, the output of Shape will always be a rank-1 vector.