Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow to check and run shape inference on a serialized model #3403

Merged
merged 1 commit into from May 4, 2021
Merged

Allow to check and run shape inference on a serialized model #3403

merged 1 commit into from May 4, 2021

Conversation

IceTDrinker
Copy link
Contributor

Avoids many serialization of a large model (when e.g. running it with onnxruntime)

Signed-off-by: IceTDrinker 49040125+IceTDrinker@users.noreply.github.com

@IceTDrinker IceTDrinker requested a review from a team as a code owner April 7, 2021 09:48
@IceTDrinker IceTDrinker changed the title Allow to check a serialized model Allow to check and run shape inference on a serialized model Apr 7, 2021
@IceTDrinker IceTDrinker marked this pull request as draft April 7, 2021 10:55
@IceTDrinker IceTDrinker force-pushed the check_serialized_model branch 2 times, most recently from 72b0e7a to d9c9cec Compare April 7, 2021 11:32
@IceTDrinker IceTDrinker marked this pull request as ready for review April 7, 2021 11:49
@IceTDrinker
Copy link
Contributor Author

If you need a squashed commit don't hesitate to ping

@IceTDrinker IceTDrinker force-pushed the check_serialized_model branch 2 times, most recently from 11a79ed to 987342e Compare April 13, 2021 08:53
@IceTDrinker IceTDrinker force-pushed the check_serialized_model branch 5 times, most recently from af88b26 to 21e79d6 Compare April 23, 2021 07:13
@IceTDrinker IceTDrinker force-pushed the check_serialized_model branch 2 times, most recently from 26840d9 to 66c0ff7 Compare April 28, 2021 07:17
@IceTDrinker
Copy link
Contributor Author

Test dependencies (protobuf) on Linux seem broken, I also see some errors related to pybind11

@IceTDrinker
Copy link
Contributor Author

gentle ping @jcwchen I saw you were working on some requirements for builds, is the failure in the Linux CI related to requirements issues ? It seems so to my untrained eye with the protobuf version apparently not being cloned properly during dependencies installation

@jcwchen
Copy link
Member

jcwchen commented Apr 28, 2021

gentle ping @jcwchen I saw you were working on some requirements for builds, is the failure in the Linux CI related to requirements issues ? It seems so to my untrained eye with the protobuf version apparently not being cloned properly during dependencies installation

Thank you for catching this. I just sent a PR to fix this

@gramalingam
Copy link
Contributor

LGTM, thanks!

@IceTDrinker
Copy link
Contributor Author

Anything I need to do on my end to be able to merge this PR ? I don't seem to be able to request a review from onnx/sig-archinfra-approvers

@jcwchen
Copy link
Member

jcwchen commented Apr 30, 2021 •
edited

Could @onnx/sig-archinfra-approvers please review this PR? Thank you.

@IceTDrinker
Allow to check a serialized model
82d5c00 
Avoids many serialization of a large model (when e.g. running it with
onnxruntime)

Allow to run shape inference on a serialized model

Signed-off-by: IceTDrinker <49040125+IceTDrinker@users.noreply.github.com>
@IceTDrinker
Copy link
Contributor Author

Hello @onnx/sig-archinfra-approvers anything else to be done for this PR ?

@jcwchen jcwchen merged commit 7b87813 into onnx:master May 4, 2021
@IceTDrinker IceTDrinker deleted the check_serialized_model branch May 6, 2021 15:17
jcwchen pushed a commit to jcwchen/onnx that referenced this pull request May 10, 2021
@IceTDrinker @jcwchen
Allow to check a serialized model (onnx#3403)
1453da6 
Avoids many serialization of a large model (when e.g. running it with
onnxruntime)

Allow to run shape inference on a serialized model

Signed-off-by: IceTDrinker <49040125+IceTDrinker@users.noreply.github.com>
neginraoof pushed a commit to neginraoof/onnx that referenced this pull request May 14, 2021
@IceTDrinker @neginraoof
Allow to check a serialized model (onnx#3403)
ba19d8c 
Avoids many serialization of a large model (when e.g. running it with
onnxruntime)

Allow to run shape inference on a serialized model

Signed-off-by: IceTDrinker <49040125+IceTDrinker@users.noreply.github.com>
Signed-off-by: neginraoof <neginmr@utexas.edu>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gramalingam gramalingam gramalingam approved these changes

@jcwchen jcwchen jcwchen approved these changes

Assignees

@askhade askhade

@gramalingam gramalingam

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@IceTDrinker @jcwchen @gramalingam @askhade