Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add requirement.txt for ONNX's dependency #3448

Merged
merged 36 commits into from
Jul 20, 2021
Merged

Conversation

jcwchen
Copy link
Member

@jcwchen jcwchen commented Apr 22, 2021

Description

  • Add ONNX's dependency as requirement.txt
    • requirement.txt: for build
    • requirement-release.txt: for release (fixed dependency version)
    • requirement-dev.txt : for development (testing)
  • To improve maintainability, reuse requirement-release.txt in all release CIs to sync dependency version easily
  • Add missing -q for each pip install

Motivation
requirement*.txt is useful for users to understand ONNX's dependency.

Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com>
Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com>
Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com>
Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com>
Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com>
Add dispatch to all CIs
Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com>
Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com>
Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com>
@jcwchen jcwchen requested a review from a team as a code owner April 22, 2021 15:48
Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com>
Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com>

# Conflicts:
#	.github/workflows/manylinux/test_package_i686.sh
#	.github/workflows/release_win.yml
Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com>
Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com>
@jcwchen jcwchen added CI pipelines Issues related to the CI pipeline build Issues related to ONNX builds and packages labels Apr 22, 2021
Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com>
Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com>
Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com>
Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com>
@jcwchen jcwchen enabled auto-merge (squash) April 30, 2021 14:15
@jcwchen jcwchen disabled auto-merge April 30, 2021 14:16
@jcwchen jcwchen mentioned this pull request May 10, 2021
@jcwchen jcwchen added the run release CIs Use this label to trigger release tests in CI label May 21, 2021
git submodule update --init --recursive
python -m pip install --upgrade setuptools
python -m pip install numpy
conda install -y -c conda-forge pybind11 protobuf

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noticed that pybind11 was removed, is this no longer necessary here?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, actually ONNX uses pybind11 as a submodule so basically it should not need to manually install pybind11 for ONNX

Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com>
Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com>
Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com>
Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com>
@jcwchen jcwchen added this to the 1.10 milestone Jul 15, 2021
requirements.txt Outdated Show resolved Hide resolved
@askhade askhade merged commit 27be295 into onnx:master Jul 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Issues related to ONNX builds and packages CI pipelines Issues related to the CI pipeline run release CIs Use this label to trigger release tests in CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants