Add UnionShape for SparseTensor TypeProto #3461
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dmitri Smirnov <dmitrism@microsoft.com>
gramalingam
reviewed
Apr 30, 2021
|
|
||
| namespace ONNX_NAMESPACE { | ||
|
|
||
| void UnionShapeInfo(const TensorShapeProto& source_shape, TensorShapeProto& target_shape) { |
There was a problem hiding this comment.
Thanks for the refactoring and moving it into a .cc file. May be useful to add a comment above that source_shape and target_shape are assumed to have same dim_size().
There was a problem hiding this comment.
I will remove it from the header
|
LGTM, thanks! Just a minor comment above. |
Signed-off-by: Dmitri Smirnov <dmitrism@microsoft.com>
Signed-off-by: Dmitri Smirnov <dmitrism@microsoft.com>
gramalingam
approved these changes
Apr 30, 2021
jcwchen
pushed a commit
to jcwchen/onnx
that referenced
this pull request
May 10, 2021
* Add UnionShape for SparseTensor TypeProto Signed-off-by: Dmitri Smirnov <dmitrism@microsoft.com> * Remove utility function from the header. Signed-off-by: Dmitri Smirnov <dmitrism@microsoft.com> * Document new utility function. Signed-off-by: Dmitri Smirnov <dmitrism@microsoft.com>
neginraoof
pushed a commit
to neginraoof/onnx
that referenced
this pull request
May 14, 2021
* Add UnionShape for SparseTensor TypeProto Signed-off-by: Dmitri Smirnov <dmitrism@microsoft.com> * Remove utility function from the header. Signed-off-by: Dmitri Smirnov <dmitrism@microsoft.com> * Document new utility function. Signed-off-by: Dmitri Smirnov <dmitrism@microsoft.com> Signed-off-by: neginraoof <neginmr@utexas.edu>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a missing utility for SparseTensor type proto