Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update protobuf version to 3.16.0 #3571

Merged
merged 5 commits into from
Jul 12, 2021
Merged

Conversation

askhade
Copy link
Contributor

@askhade askhade commented Jul 9, 2021

Signed-off-by: Ashwini Khade askhade@microsoft.com

Description
Updating the protobuf version to 3.16.0

  • Describe your changes.

Motivation and Context

  • Why is this change required? What problem does it solve?
  • If it fixes an open issue, please link to the issue here.

Signed-off-by: Ashwini Khade <askhade@microsoft.com>
@askhade askhade added the run release CIs Use this label to trigger release tests in CI label Jul 9, 2021
@askhade askhade added this to the 1.10 milestone Jul 9, 2021
@askhade askhade requested a review from a team as a code owner July 9, 2021 18:16
Signed-off-by: Ashwini Khade <askhade@microsoft.com>
@askhade askhade requested a review from jcwchen July 12, 2021 04:39
Signed-off-by: Ashwini Khade <askhade@microsoft.com>
@askhade askhade enabled auto-merge (squash) July 12, 2021 17:07
@askhade askhade disabled auto-merge July 12, 2021 18:07
@askhade askhade merged commit 4b37652 into onnx:master Jul 12, 2021
@garymm
Copy link
Contributor

garymm commented Nov 11, 2021

@askhade in the future could you please fill out the Why is this change required? What problem does it solve? section of the PR description?

This change actually caused us some trouble integrating ONNX 1.10 into PyTorch and it'd be nice to understand the context.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
run release CIs Use this label to trigger release tests in CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants