Use 0D tensors for scalar inputs in testcases #3583
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shinh
force-pushed
the
1d-to-scalar
branch
2 times, most recently
from
9ac0d38
to
0b967e1
Compare
Signed-off-by: Shinichiro Hamaji <shinichiro.hamaji@gmail.com>
|
@shinh : I agree with you regarding this inconsistency. I have also encountered this issue more than once and I believe we need to clarify the treatment of scalars and 1D tensors of len 1. Should they be treated as same or not. here is the issue I created: #2428 I will propose this topic for Oct Arch-Infra-Op Sig meeting. |
askhade
reviewed
Feb 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Testcases of OneHot, SequenceInsert, and NonMaxSuppression were using 1D tensor as scalar inputs but their documents say they accept scalars.
Motivation and Context
These tests look inconsistent with the document and I could not find any document which mentions 1D tensor with a single element can be treated as a scalar. Especially, the document of SequenceInsert clearly states
positionshould be "tensor of empty shape".I felt the second input of TopK op should be also a scalar, but the document says it takes 1D tensor with a single element.