Extend Where op to permit bfloat16 types #3738
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ganesan Ramalingam <grama@microsoft.com>
Signed-off-by: Ganesan Ramalingam <grama@microsoft.com>
Signed-off-by: Ganesan Ramalingam <grama@microsoft.com>
|
Is BFLoat16 support required for this OP? Meaning is any runtime blocked currently or is this simply to close the gap? |
The function definition of DropoutGrad, for example, does not work for bfloat16, because the Where op does not support bfloat16. (See:https://github.com/microsoft/onnxruntime/blob/7d28b596f482f70052cc9e58374455bd5af7c92d/orttraining/orttraining/core/graph/training_op_defs.cc#L1702 ). |
askhade
approved these changes
Sep 28, 2021
mhamilton723
pushed a commit
to mhamilton723/onnx
that referenced
this pull request
Oct 22, 2021
* Update Where op to allow bfloat16 Signed-off-by: Ganesan Ramalingam <grama@microsoft.com> * Update doc formatting Signed-off-by: Ganesan Ramalingam <grama@microsoft.com> * Address flake8 warnings Signed-off-by: Ganesan Ramalingam <grama@microsoft.com> Co-authored-by: Ashwini Khade <askhade@microsoft.com> Signed-off-by: Mark <mhamilton723@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Update the Where op to allow bfloat type.
Motivation and Context
Looks like this op was overlooked when bfloat type was added.