Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Linux aarch64 CI failure due to the latest pytest (#3736) #3773

Merged
merged 1 commit into from
Oct 22, 2021
Merged

Fix Linux aarch64 CI failure due to the latest pytest (#3736) #3773

merged 1 commit into from
Oct 22, 2021

Conversation

postrational
Copy link
Contributor

@postrational postrational commented Oct 13, 2021 •
edited

This PR is porting PR #3736 to release branch for version 1.10.2

Solution: Use old qemu docker

  • revert bfloat16

Signed-off-by: Chun-Wei Chen jacky82226@gmail.com

  • add back bfloat16 but does not reverse it

Signed-off-by: Chun-Wei Chen jacky82226@gmail.com

  • typo

Signed-off-by: Chun-Wei Chen jacky82226@gmail.com

  • use 5.4.3 pytest

Signed-off-by: Chun-Wei Chen jacky82226@gmail.com

  • testing: simply install onnx from pypi

Signed-off-by: Chun-Wei Chen jacky82226@gmail.com

  • onnx-weekly

Signed-off-by: Chun-Wei Chen jacky82226@gmail.com

  • onnx-weekly

Signed-off-by: Chun-Wei Chen jacky82226@gmail.com

  • 1.10.1

Signed-off-by: Chun-Wei Chen jacky82226@gmail.com

  • typo

Signed-off-by: Chun-Wei Chen jacky82226@gmail.com

  • fix jupyter-client==7.0.2

Signed-off-by: Chun-Wei Chen jacky82226@gmail.com

  • jupyter-core

Signed-off-by: Chun-Wei Chen jacky82226@gmail.com

  • no py3.6

Signed-off-by: Chun-Wei Chen jacky82226@gmail.com

  • older 6.4.0 jupyter-client

Signed-off-by: Chun-Wei Chen jacky82226@gmail.com

  • only 4.7.1

Signed-off-by: Chun-Wei Chen jacky82226@gmail.com

  • sync the pip dependencies

Signed-off-by: Chun-Wei Chen jacky82226@gmail.com

  • more_itertools==8.9.0

Signed-off-by: Chun-Wei Chen jacky82226@gmail.com

  • correct

Signed-off-by: Chun-Wei Chen jacky82226@gmail.com

  • test with rel-1-.10.1

Signed-off-by: Chun-Wei Chen jacky82226@gmail.com

  • git checkout rel-1.10.1

Signed-off-by: Chun-Wei Chen jacky82226@gmail.com

  • skip building

Signed-off-by: Chun-Wei Chen jacky82226@gmail.com

  • latest pytest and ipython

Signed-off-by: Chun-Wei Chen jacky82226@gmail.com

  • jupyter convert

Signed-off-by: Chun-Wei Chen jacky82226@gmail.com

  • jupyter nbconvert --to notebook --inplace --execute

Signed-off-by: Chun-Wei Chen jacky82226@gmail.com

  • still use main branch

Signed-off-by: Chun-Wei Chen jacky82226@gmail.com

  • ubuntu-18.04

Signed-off-by: Chun-Wei Chen jacky82226@gmail.com

  • python -m pip install notebook==6.4.0

Signed-off-by: Chun-Wei Chen jacky82226@gmail.com

  • pip install jupyterlab==3.1.10

Signed-off-by: Chun-Wei Chen jacky82226@gmail.com

  • add troubleshoot

Signed-off-by: Chun-Wei Chen jacky82226@gmail.com

  • use old image binfmt

Signed-off-by: Chun-Wei Chen jacky82226@gmail.com

  • typo

Signed-off-by: Chun-Wei Chen jacky82226@gmail.com

  • use master

Signed-off-by: Chun-Wei Chen jacky82226@gmail.com

  • use exact the same docker

Signed-off-by: Chun-Wei Chen jacky82226@gmail.com

  • get rid of others

Signed-off-by: Chun-Wei Chen jacky82226@gmail.com

  • revert mapping which is unrelated

Signed-off-by: Chun-Wei Chen jacky82226@gmail.com

  • add TODO comment

Signed-off-by: Chun-Wei Chen jacky82226@gmail.com

Co-authored-by: Ashwini Khade askhade@microsoft.com

Description

  • Describe your changes.

Motivation and Context

  • Why is this change required? What problem does it solve?
  • If it fixes an open issue, please link to the issue here.

@jcwchen @askhade @postrational
Fix Linux aarch64 CI failure due to the latest pytest: use old qemu d…
c14b668 
…ocker (onnx#3736)

* revert bfloat16

Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com>

* add back bfloat16 but does not reverse it

Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com>

* typo

Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com>

* use 5.4.3 pytest

Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com>

* testing: simply install onnx from pypi

Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com>

* onnx-weekly

Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com>

* onnx-weekly

Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com>

* 1.10.1

Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com>

* typo

Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com>

* fix jupyter-client==7.0.2

Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com>

* jupyter-core

Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com>

* no py3.6

Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com>

* older 6.4.0 jupyter-client

Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com>

* only 4.7.1

Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com>

* sync the pip dependencies

Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com>

* more_itertools==8.9.0

Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com>

* correct

Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com>

* test with rel-1-.10.1

Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com>

* git checkout rel-1.10.1

Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com>

* skip building

Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com>

* latest pytest and ipython

Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com>

* jupyter convert

Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com>

* jupyter nbconvert --to notebook --inplace --execute

Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com>

* still use main branch

Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com>

* ubuntu-18.04

Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com>

* python -m pip install notebook==6.4.0

Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com>

* pip install jupyterlab==3.1.10

Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com>

* add troubleshoot

Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com>

* use old image binfmt

Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com>

* typo

Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com>

* use master

Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com>

* use exact the same docker

Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com>

* get rid of others

Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com>

* revert mapping which is unrelated

Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com>

* add TODO comment

Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com>

Co-authored-by: Ashwini Khade <askhade@microsoft.com>
@postrational postrational requested a review from a team as a code owner October 13, 2021 10:50
jcwchen
jcwchen approved these changes Oct 13, 2021
View reviewed changes
Copy link
Member

@jcwchen jcwchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you for picking this fix and driving 1.10.2 release!

@askhade
Copy link
Contributor

askhade commented Oct 13, 2021

@postrational can you list the changes we are picking for 1.10.2 in this wiki - https://github.com/onnx/onnx/wiki/Logistics-for-ONNX-Release-1.10

@jcwchen : Can you make sure we are picking the recent shape inference fix for shape op

@postrational postrational merged commit 87435aa into onnx:rel-1.10.2 Oct 22, 2021
@postrational postrational deleted the rel-1.10.2-fix branch October 22, 2021 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@askhade askhade askhade approved these changes

@jcwchen jcwchen jcwchen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@postrational @askhade @jcwchen