Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarify that op_type is case sensitive #4096

Merged
merged 1 commit into from
Mar 29, 2022
Merged

Clarify that op_type is case sensitive #4096

merged 1 commit into from
Mar 29, 2022

Conversation

fdwr
Copy link
Contributor

@fdwr fdwr commented Mar 29, 2022 •
edited
Loading

This is consistent with current precedent. e.g. ONNX Runtime fails with "conv ... Error No Op registered for conv with domain_version of 7", as it must be "Conv".

Description

  • Update IR.md to clarify op type case sensitivity.

Motivation and Context

@fdwr
Clarify that op_type is case sensitive
5761615 
This is consistent with current precedent. e.g. ONNX Runtime fails with "conv ... Error No Op registered for conv with domain_version of 7", as it must be "Conv".

Signed-off-by: Dwayne Robinson <dwayner@microsoft.com>
@fdwr fdwr requested a review from a team as a code owner March 29, 2022 05:10
@fdwr
Copy link
Contributor Author

fdwr commented Mar 29, 2022

FYI @jcwchen and @spandantiwari.

@jcwchen jcwchen added build Issues related to ONNX builds and packages documentation Issues related to ONNX documentation and removed build Issues related to ONNX builds and packages labels Mar 29, 2022
@jcwchen jcwchen linked an issue Mar 29, 2022 that may be closed by this pull request
Case sensitivity of operator names and attributes #1934
Closed
jcwchen
jcwchen approved these changes Mar 29, 2022
View reviewed changes
Copy link
Member

@jcwchen jcwchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you for the spec clarification! Could @onnx/sig-archinfra-approvers please review it?

@jcwchen jcwchen added the spec clarification Clarification of the ONNX spec needed label Mar 29, 2022
@gramalingam gramalingam merged commit ee4888c into onnx:main Mar 29, 2022
wschin pushed a commit to wschin/onnx that referenced this pull request Apr 12, 2022
@fdwr @wschin
Clarify that op_type is case sensitive (onnx#4096)
33b5b56 
This is consistent with current precedent. e.g. ONNX Runtime fails with "conv ... Error No Op registered for conv with domain_version of 7", as it must be "Conv".

Signed-off-by: Dwayne Robinson <dwayner@microsoft.com>
broune pushed a commit to broune/onnx that referenced this pull request May 6, 2023
@fdwr
Clarify that op_type is case sensitive (onnx#4096)
13007d8 
This is consistent with current precedent. e.g. ONNX Runtime fails with "conv ... Error No Op registered for conv with domain_version of 7", as it must be "Conv".

Signed-off-by: Dwayne Robinson <dwayner@microsoft.com>
@fdwr fdwr mentioned this pull request May 15, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gramalingam gramalingam gramalingam approved these changes

@jcwchen jcwchen jcwchen approved these changes

Assignees
No one assigned
Labels
documentation Issues related to ONNX documentation spec clarification Clarification of the ONNX spec needed
Projects
PR Tracker
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Case sensitivity of operator names and attributes
3 participants
@fdwr @gramalingam @jcwchen