Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use getShapeInput in shape inference for ConstantOfShape #4141

Merged
merged 2 commits into from
Apr 22, 2022
Merged

Use getShapeInput in shape inference for ConstantOfShape #4141

merged 2 commits into from
Apr 22, 2022

Conversation

xuzijian629
Copy link
Member

Description

  • Use getShapeInput in the shape inference for ConstantOfShape.

Motivation and Context

  • This makes the code simpler.

@xuzijian629
Update shape inference for constant of shape
733e9e6 
Signed-off-by: Joe <joe@preferred.jp>
@xuzijian629 xuzijian629 requested a review from a team as a code owner April 14, 2022 23:59
@jcwchen jcwchen added the shape inference Issues related to shape inference label Apr 21, 2022
jcwchen
jcwchen approved these changes Apr 21, 2022
View reviewed changes
Copy link
Member

@jcwchen jcwchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you for simplifying.

@jcwchen jcwchen merged commit 92be333 into onnx:main Apr 22, 2022
@xuzijian629 xuzijian629 deleted the constant_of_shape branch April 22, 2022 23:27
liqunfu pushed a commit to liqunfu/onnx that referenced this pull request May 17, 2022
@xuzijian629 @jcwchen @liqunfu
Update shape inference for constant of shape (onnx#4141)
33bfdd8 
Signed-off-by: Joe <joe@preferred.jp>

Co-authored-by: Chun-Wei Chen <jacky82226@gmail.com>
Signed-off-by: Liqun Fu <liqfu@microsoft.com>
broune pushed a commit to broune/onnx that referenced this pull request May 6, 2023
@xuzijian629 @jcwchen
Update shape inference for constant of shape (onnx#4141)
538b48a 
Signed-off-by: Joe <joe@preferred.jp>

Co-authored-by: Chun-Wei Chen <jacky82226@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gramalingam gramalingam gramalingam approved these changes

@jcwchen jcwchen jcwchen approved these changes

Assignees
No one assigned
Labels
shape inference Issues related to shape inference
Projects
PR Tracker
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@xuzijian629 @gramalingam @jcwchen