Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify add new op documentation #4150

Merged
merged 2 commits into from
May 11, 2022
Merged

Conversation

gramalingam
Copy link
Contributor

Signed-off-by: Ganesan Ramalingam grama@microsoft.com

Description
Update documentation on adding new op.

Motivation and Context
Clarify philosophy and the complexity-generality tradeoff.

Signed-off-by: Ganesan Ramalingam <grama@microsoft.com>
@gramalingam gramalingam requested a review from a team as a code owner April 19, 2022 18:55
@gramalingam gramalingam added this to the 1.12 milestone Apr 19, 2022
Copy link
Contributor

@askhade askhade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gramalingam gramalingam merged commit 12c318e into onnx:main May 11, 2022
@gramalingam gramalingam deleted the add-new-op branch May 11, 2022 22:24
liqunfu pushed a commit to liqunfu/onnx that referenced this pull request May 17, 2022
Signed-off-by: Ganesan Ramalingam <grama@microsoft.com>
Signed-off-by: Liqun Fu <liqfu@microsoft.com>
broune pushed a commit to broune/onnx that referenced this pull request May 6, 2023
Signed-off-by: Ganesan Ramalingam <grama@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants