Update shape inference documentation #4163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ganesan Ramalingam <grama@microsoft.com>
jcwchen
reviewed
Apr 25, 2022
Signed-off-by: Ganesan Ramalingam <grama@microsoft.com>
jcwchen
approved these changes
Apr 26, 2022
xadupre
reviewed
Apr 26, 2022
xadupre
reviewed
Apr 26, 2022
| handle the possibility that the dimension may not have a statically | ||
| known value. | ||
|
|
||
| There are several utility functions in [shape_inference.h](/onnx/defs/shape_inference.h) |
There was a problem hiding this comment.
Should we make sure users are using the utility functions to throw exceptions if one shape has an unexpecgted value?
There was a problem hiding this comment.
Yes, but, unfortunately, we are dependent on reviewers to check for this. Any other suggestions?
Signed-off-by: Ganesan Ramalingam <grama@microsoft.com>
liqunfu
pushed a commit
to liqunfu/onnx
that referenced
this pull request
May 17, 2022
* Update shape inference documentation Signed-off-by: Ganesan Ramalingam <grama@microsoft.com> * Add an example. Signed-off-by: Ganesan Ramalingam <grama@microsoft.com> * Move sub-section Signed-off-by: Ganesan Ramalingam <grama@microsoft.com> Signed-off-by: Liqun Fu <liqfu@microsoft.com>
broune
pushed a commit
to broune/onnx
that referenced
this pull request
May 6, 2023
* Update shape inference documentation Signed-off-by: Ganesan Ramalingam <grama@microsoft.com> * Add an example. Signed-off-by: Ganesan Ramalingam <grama@microsoft.com> * Move sub-section Signed-off-by: Ganesan Ramalingam <grama@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Ganesan Ramalingam grama@microsoft.com
Description
Update the shape-inference documentation.
Motivation and Context
Helps developers who write shape-inference code for operators avoid some common mistakes.