Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use ONNX Runtime PyPI package instead of ort-nightly #4219

Merged
merged 2 commits into from May 25, 2022

Conversation

jcwchen
Copy link
Member

@jcwchen jcwchen commented May 24, 2022

Description
Use ONNX Runtime PyPI package instead of ort-nightly in all release CIs to fix current CI failure because of missing ort-nightly packages.

Motivation and Context
Previously ONNX repo uses ort-nightly TestPyPI packages to run a simple test. However, microsoft/onnxruntime#11613 (comment) actually ort-nightly on TestPyPI is not used for external testing. Using ONNX Runtime PyPI package to validate the combined usage of ONNX and ORT should be sufficient.

Signed-off-by: jcwchen <jacky82226@gmail.com>
@jcwchen jcwchen added CI pipelines Issues related to the CI pipeline run release CIs Use this label to trigger release tests in CI labels May 24, 2022
@jcwchen jcwchen requested a review from a team as a code owner May 24, 2022 18:56
@jcwchen jcwchen added this to the 1.12 milestone May 24, 2022
@jcwchen jcwchen mentioned this pull request May 24, 2022
Signed-off-by: jcwchen <jacky82226@gmail.com>
@jcwchen jcwchen merged commit eb84799 into onnx:main May 25, 2022
@jcwchen jcwchen deleted the jcw/ci/use-ort branch May 25, 2022 00:41
justinchuby pushed a commit to justinchuby/onnx that referenced this pull request May 25, 2022
* Use ONNX Runtime PyPI package instead of ort-nightly

Signed-off-by: jcwchen <jacky82226@gmail.com>

* nit: use onnxruntime instead of ort-nightly in TODO

Signed-off-by: jcwchen <jacky82226@gmail.com>
Signed-off-by: Justin Chu <justinchu@microsoft.com>
@snnn
Copy link
Contributor

snnn commented Aug 3, 2022

I setup a new feed to replace the testpypi one: https://aiinfra.visualstudio.com/PublicPackages/_artifacts/feed/ORT-Nightly/connect/pip
The new one is hosted on ADO. It is fully under ONNX Runtime's control. It doesn't have storage limit. So I do not need to delete old packages every week.

@jcwchen
Copy link
Member Author

jcwchen commented Aug 3, 2022

Thank @snnn for the effort and update! That's great to know and I will keep in mind for future use case.

broune pushed a commit to broune/onnx that referenced this pull request May 6, 2023
* Use ONNX Runtime PyPI package instead of ort-nightly

Signed-off-by: jcwchen <jacky82226@gmail.com>

* nit: use onnxruntime instead of ort-nightly in TODO

Signed-off-by: jcwchen <jacky82226@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI pipelines Issues related to the CI pipeline run release CIs Use this label to trigger release tests in CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants