Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some typos. #4228

Merged
merged 3 commits into from Jun 3, 2022
Merged

Fix some typos. #4228

merged 3 commits into from Jun 3, 2022

Conversation

Yulv-git
Copy link
Contributor

Description
Fix some typos.

Motivation and Context

Fix some typos for doc and comments.

@Yulv-git Yulv-git requested review from a team as code owners May 28, 2022 04:41
Copy link
Member

@jcwchen jcwchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for catching these. To fix CI failure, please run

python onnx/defs/gen_doc.py
ONNX_ML=0 python onnx/defs/gen_doc.py

to regenerated Operators.md and Operators-ml.md from updated defs.cc and old.cc files.

@Yulv-git
Copy link
Contributor Author

Thank you for catching these. To fix CI failure, please run

python onnx/defs/gen_doc.py
ONNX_ML=0 python onnx/defs/gen_doc.py

to regenerated Operators.md and Operators-ml.md from updated defs.cc and old.cc files.

Thanks for your help!

@jcwchen
Copy link
Member

jcwchen commented May 28, 2022

No problem! Please note that after updating defs.cc and old.cc, you will need to build ONNX from source (for instance, pip install -e .) before running document generation. It seems that you were not using the right installed ONNX in your latest commit so there are still some difference failure in CIs.

Copy link
Member

@jcwchen jcwchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick update! Now the CIs all passed. One last thing: you need to sign-off all your commits by DCO: https://github.com/onnx/onnx/blob/main/CONTRIBUTING.md#dco

@jcwchen jcwchen added the documentation Issues related to ONNX documentation label May 31, 2022
Signed-off-by: Yulv-git <yulvchi@qq.com>
@Yulv-git
Copy link
Contributor Author

Yulv-git commented Jun 3, 2022

Thanks for the quick update! Now the CIs all passed. One last thing: you need to sign-off all your commits by DCO: https://github.com/onnx/onnx/blob/main/CONTRIBUTING.md#dco

Thanks for your guidance. There may be no problem with the current PR.

Copy link
Member

@jcwchen jcwchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. cc @onnx/sig-operators-approvers

@jcwchen jcwchen enabled auto-merge (squash) June 3, 2022 20:49
@jcwchen jcwchen merged commit 6a89ca2 into onnx:main Jun 3, 2022
@Yulv-git Yulv-git deleted the typos1 branch June 24, 2022 14:38
broune pushed a commit to broune/onnx that referenced this pull request May 6, 2023
Signed-off-by: Yulv-git <yulvchi@qq.com>

Co-authored-by: Chun-Wei Chen <jacky82226@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Issues related to ONNX documentation
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants