New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix some typos. #4228
Fix some typos. #4228
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for catching these. To fix CI failure, please run
python onnx/defs/gen_doc.py
ONNX_ML=0 python onnx/defs/gen_doc.py
to regenerated Operators.md and Operators-ml.md from updated defs.cc and old.cc files.
Thanks for your help! |
No problem! Please note that after updating defs.cc and old.cc, you will need to build ONNX from source (for instance, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the quick update! Now the CIs all passed. One last thing: you need to sign-off all your commits by DCO: https://github.com/onnx/onnx/blob/main/CONTRIBUTING.md#dco
Signed-off-by: Yulv-git <yulvchi@qq.com>
Thanks for your guidance. There may be no problem with the current PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. cc @onnx/sig-operators-approvers
Signed-off-by: Yulv-git <yulvchi@qq.com> Co-authored-by: Chun-Wei Chen <jacky82226@gmail.com>
Description
Fix some typos.
Motivation and Context
Fix some typos for doc and comments.