-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix layer normalization's reference outputs #4263
Conversation
* Update requirements.txt (#4223) * Upgrade python syntax with pyupgrade (#4212) Signed-off-by: Eduardo <eduardomoreno2594@gmail.com> * Update requirements.txt Signed-off-by: Eduardo <eduardomoreno2594@gmail.com> * include the previous restriction as well Signed-off-by: Eduardo <eduardomoreno2594@gmail.com> Co-authored-by: Justin Chu <justinchuby@users.noreply.github.com> * Change version number to 1.12.0rc1 for testing Signed-off-by: Ettore Tiotto <etiotto@ca.ibm.com> Co-authored-by: EduMoreno <eduardomoreno2594@gmail.com> Co-authored-by: Justin Chu <justinchuby@users.noreply.github.com> Co-authored-by: Chun-Wei Chen <jacky82226@gmail.com>
Signed-off-by: Ettore Tiotto <etiotto@ca.ibm.com> Co-authored-by: Chun-Wei Chen <jacky82226@gmail.com>
Signed-off-by: Ettore Tiotto <etiotto@ca.ibm.com>
Signed-off-by: Wei-Sheng Chin <wschin@outlook.com>
c90f152
to
b8e32c2
Compare
This reverts commit 4beb71f. Signed-off-by: Wei-Sheng Chin <wschin@outlook.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
@@ -1 +1 @@ | |||
1.12.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oops :-)
I'll send a fix.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! This is fixed in main
branch but I didn't touch release branch.
Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com>
* Use op name rather than hard-coding Hann in window op doc strings. (#4248) And strip trailing spaces. Signed-off-by: Gary Miguel <garymiguel@microsoft.com> Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com> * Fix: Window functions generate incorrect shape for with symmetric attribute (#4256) * fix symmetric function definition, and add shape inference test Signed-off-by: Sheil Kumar <smk2007@gmail.com> * whitespace... Signed-off-by: Sheil Kumar <smk2007@gmail.com> * whitespace... Signed-off-by: Sheil Kumar <smk2007@gmail.com> * flake8 whitespace error Signed-off-by: Sheil Kumar <smk2007@gmail.com> * fix stft test Signed-off-by: Sheil Kumar <smk2007@gmail.com> Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com> * support truncation & fix big-endian support (#4238) Signed-off-by: Ian Bearman <ianb@microsoft.com> Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com> * Fix layer normalization's reference outputs (#4263) Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com> * handle raw types correctly in helper.make_tensor (#4262) Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com> * bump to 1.12.0rc4 for cherry-picks Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com> * Fix sub-graph generation for LN (#4268) Signed-off-by: Wei-Sheng Chin <wschin@outlook.com> Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com> Co-authored-by: Gary Miguel <garymiguel@microsoft.com> Co-authored-by: Sheil Kumar <smk2007@gmail.com> Co-authored-by: Ian Bearman <ianb@microsoft.com> Co-authored-by: Wei-Sheng Chin <wschin@outlook.com>
Existing outputs are always generated using default
epsilon
, so the reference outputs with non-defaultepsilon
are incorrect. This PR fixes this problem. This change is tested with ONNXRuntime (commit: aceaa0a1f7ebc8919999c7b0e88bb565373c1e6d) and the tests are passing.