Remove reference to numpy.typing #4277
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* bump version to 1.12.0 Signed-off-by: Ettore Tiotto <etiotto@ca.ibm.com> * Remove trailing white space Signed-off-by: Ettore Tiotto <etiotto@ca.ibm.com> Co-authored-by: Chun-Wei Chen <jacky82226@gmail.com> Signed-off-by: Justin Chu <justinchu@microsoft.com>
Signed-off-by: Justin Chu <justinchu@microsoft.com>
Signed-off-by: Justin Chu <justinchu@microsoft.com>
justinchuby
force-pushed
the
justinchu/typing
branch
from
d756403
to
f1e2b3c
Compare
|
@jcwchen we prob need a newer version of typing_extensions: python/typing#724 |
jcwchen
reviewed
Jun 15, 2022
Co-authored-by: Chun-Wei Chen <jacky82226@gmail.com> Signed-off-by: Justin Chu <justinchu@microsoft.com>
Signed-off-by: Justin Chu <justinchu@microsoft.com>
justinchuby
force-pushed
the
justinchu/typing
branch
from
df41b2c
to
fa07c93
Compare
jcwchen
reviewed
Jun 15, 2022
jcwchen
approved these changes
Jun 15, 2022
There was a problem hiding this comment.
Thank you @justinchuby for the quick fix! To prevent similar issues in the future, I add the verification for the minimum supported NumPy version in CIs by this PR. Hopefully in the future we can catch this issue in ONNX CIs first.
liqunfu
approved these changes
Jun 15, 2022
|
Could you update the rc so that it can be tested in pytorch? |
liqunfu
pushed a commit
that referenced
this pull request
Jun 15, 2022
* bump version to 1.12.0 (#4209) * bump version to 1.12.0 Signed-off-by: Ettore Tiotto <etiotto@ca.ibm.com> * Remove trailing white space Signed-off-by: Ettore Tiotto <etiotto@ca.ibm.com> Co-authored-by: Chun-Wei Chen <jacky82226@gmail.com> Signed-off-by: Justin Chu <justinchu@microsoft.com> * Update numpy_helper.py Signed-off-by: Justin Chu <justinchu@microsoft.com> * Update numpy_helper.py Signed-off-by: Justin Chu <justinchu@microsoft.com> * Update onnx/numpy_helper.py Co-authored-by: Chun-Wei Chen <jacky82226@gmail.com> Signed-off-by: Justin Chu <justinchu@microsoft.com> * Update numpy_helper.py Signed-off-by: Justin Chu <justinchu@microsoft.com> * syntax Signed-off-by: Justin Chu <justinchu@microsoft.com> Co-authored-by: Ettore Tiotto <etiotto@gmail.com> Co-authored-by: Chun-Wei Chen <jacky82226@gmail.com>
liqunfu
pushed a commit
that referenced
this pull request
Jun 15, 2022
* bump version to 1.12.0 (#4209) * bump version to 1.12.0 Signed-off-by: Ettore Tiotto <etiotto@ca.ibm.com> * Remove trailing white space Signed-off-by: Ettore Tiotto <etiotto@ca.ibm.com> Co-authored-by: Chun-Wei Chen <jacky82226@gmail.com> Signed-off-by: Justin Chu <justinchu@microsoft.com> * Update numpy_helper.py Signed-off-by: Justin Chu <justinchu@microsoft.com> * Update numpy_helper.py Signed-off-by: Justin Chu <justinchu@microsoft.com> * Update onnx/numpy_helper.py Co-authored-by: Chun-Wei Chen <jacky82226@gmail.com> Signed-off-by: Justin Chu <justinchu@microsoft.com> * Update numpy_helper.py Signed-off-by: Justin Chu <justinchu@microsoft.com> * syntax Signed-off-by: Justin Chu <justinchu@microsoft.com> Co-authored-by: Ettore Tiotto <etiotto@gmail.com> Co-authored-by: Chun-Wei Chen <jacky82226@gmail.com> Signed-off-by: Liqun Fu <liqfu@microsoft.com>
broune
pushed a commit
to broune/onnx
that referenced
this pull request
May 6, 2023
* bump version to 1.12.0 (onnx#4209) * bump version to 1.12.0 Signed-off-by: Ettore Tiotto <etiotto@ca.ibm.com> * Remove trailing white space Signed-off-by: Ettore Tiotto <etiotto@ca.ibm.com> Co-authored-by: Chun-Wei Chen <jacky82226@gmail.com> Signed-off-by: Justin Chu <justinchu@microsoft.com> * Update numpy_helper.py Signed-off-by: Justin Chu <justinchu@microsoft.com> * Update numpy_helper.py Signed-off-by: Justin Chu <justinchu@microsoft.com> * Update onnx/numpy_helper.py Co-authored-by: Chun-Wei Chen <jacky82226@gmail.com> Signed-off-by: Justin Chu <justinchu@microsoft.com> * Update numpy_helper.py Signed-off-by: Justin Chu <justinchu@microsoft.com> * syntax Signed-off-by: Justin Chu <justinchu@microsoft.com> Co-authored-by: Ettore Tiotto <etiotto@gmail.com> Co-authored-by: Chun-Wei Chen <jacky82226@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Remove reference to numpy.typing
Motivation and Context
onnx supports numpy > 1.16 (from requirements.txt) but
numpy.typingis introduced in 1.20. The PR removesnumpy.typingand instead creates the_ShapeLiketype.combine_pairs_to_complexhelperNeeded for the 1.12 release