Revert #3979: Checker should validate the node's inputs/outputs have names when Variadic #4283
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcwchen
added
onnx checker
run release CIs
liqunfu
approved these changes
Jun 16, 2022
gramalingam
approved these changes
Jun 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Revert #3979: Checker should validate the node's inputs/outputs have names when Variadic
Motivation and Context
It seems possible that some operators set Variadic for some dynamic situations. For instance, PythonOpGrad from ORT might have an empty input for Variadic input. To unblock the failure right before the release, loosen the onnx.checker for now. Going forward, we should consider to make the check only for Loop op. Reopen issue #3969 for future tracking.