add is_constant_initializer in ir.h #4336
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: daquexian <daquexian566@gmail.com>
jcwchen
approved these changes
Jul 1, 2022
broune
pushed a commit
to broune/onnx
that referenced
this pull request
May 6, 2023
Signed-off-by: daquexian <daquexian566@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add
Graph::is_constant_initializer(const Value*) constin ir.hMotivation and Context
Why is this change required? What problem does it solve?
I'm developing onnx optimizer and find that it is helpful to have an
is_constant_initializermethod to check whether a Value is an initializer but not an input (a.k.a. a constant initializer). Only constant initializers can be safely eliminated or fused.