Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarify and add helper for making attribute references #4393

Merged
merged 3 commits into from Aug 2, 2022
Merged

Clarify and add helper for making attribute references #4393

merged 3 commits into from Aug 2, 2022

Conversation

jbachurski
Copy link
Member

Description

  • Adds onnx.helper.make_attribute_ref to create parent function attribute references.
  • Explains the mechanism of passing attribute references in IR.md.

Motivation and Context

@jbachurski
Add make_attribute_ref
8c34709 
Signed-off-by: KubinGH <kbachurski@gmail.com>
@jbachurski
Add note about ref_attr_name
2d36273 
Signed-off-by: KubinGH <kbachurski@gmail.com>
@jbachurski jbachurski requested a review from a team as a code owner July 29, 2022 13:29
gramalingam
gramalingam approved these changes Aug 2, 2022
View reviewed changes
Copy link
Contributor

@gramalingam gramalingam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@jcwchen jcwchen merged commit 5e1c1bb into onnx:main Aug 2, 2022
broune pushed a commit to broune/onnx that referenced this pull request May 6, 2023
Clarify and add helper for making attribute references (onnx#4393)
4cc6461 
* Add make_attribute_ref

Signed-off-by: KubinGH <kbachurski@gmail.com>

* Add note about ref_attr_name

Signed-off-by: KubinGH <kbachurski@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gramalingam gramalingam gramalingam approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Referencing function attributes in body
3 participants
@jbachurski @gramalingam @jcwchen