Add py.typed to let mypy get stub for type information #4412
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com>
jcwchen
added
build
jbachurski
suggested changes
Aug 7, 2022
There was a problem hiding this comment.
I think this proposed change both universally fixes the typing error on my setup & properly types proto objects and their fields (see my comment: #4404 (comment))
Co-authored-by: Jakub Bachurski <KubinGH@users.noreply.github.com> Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com>
jbachurski
approved these changes
Aug 9, 2022
gramalingam
reviewed
Aug 10, 2022
gramalingam
approved these changes
Aug 10, 2022
Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com>
jcwchen
commented
Aug 10, 2022
| @@ -340,6 +340,7 @@ def run(self): | |||
| packages=packages, | |||
| license="Apache License v2.0", | |||
| include_package_data=True, | |||
| package_data={"onnx": ["py.typed", "*.pyi"]}, | |||
There was a problem hiding this comment.
One nit update: I removed adding py.typed in MANIFEST.in, because I think this line L343 will do the same thing here. I have tested that the updated ONNX wheel can still produce correct type information.
broune
pushed a commit
to broune/onnx
that referenced
this pull request
May 6, 2023
* Add py.typed to let mypy get stub for type information Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com> * Update setup.py Co-authored-by: Jakub Bachurski <KubinGH@users.noreply.github.com> Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com> * add EOF Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com> * remove py.typed in MANIFEST because package_data has included it Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com> Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com> Co-authored-by: Jakub Bachurski <KubinGH@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Motivation and Context
Fixes #4404.