New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
to extend OptionalHasElement and OptionalGetElement to accept tensor and sequence types #4421
Merged
Merged
Changes from 3 commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
150c0c3
extend OptionalHasElement and OptionalGetElement to accept tensor and…
liqunfu 6c1d5fd
update doc and test cases
liqunfu 79a059c
fix style check
liqunfu ca4dece
update with reviewer's comments
liqunfu 22cfe7c
test data
liqunfu 8d787fa
update with reviewer's comment to remove a test case of empty tensor …
liqunfu bdbe433
merge main
liqunfu 41ae84a
black
liqunfu 88e5a77
undo change to onnx/numpy_helper.py
liqunfu 0666e84
undo change to onnx/numpy_helper.py
liqunfu ed190fd
Merge branch 'main' into liqun/optionalHasElementExt
liqunfu File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binary file modified
BIN
+0 Bytes
(100%)
onnx/backend/test/data/node/test_optional_get_element/model.onnx
Binary file not shown.
Binary file modified
BIN
+0 Bytes
(100%)
onnx/backend/test/data/node/test_optional_get_element_sequence/model.onnx
Binary file not shown.
Binary file modified
BIN
+0 Bytes
(100%)
onnx/backend/test/data/node/test_optional_has_element/model.onnx
Binary file not shown.
Binary file modified
BIN
+0 Bytes
(100%)
onnx/backend/test/data/node/test_optional_has_element_empty/model.onnx
Binary file not shown.
Binary file added
BIN
+157 Bytes
onnx/backend/test/data/node/test_optional_has_element_tensor/model.onnx
Binary file not shown.
Binary file added
BIN
+42 Bytes
onnx/backend/test/data/node/test_optional_has_element_tensor/test_data_set_0/input_0.pb
Binary file not shown.
1 change: 1 addition & 0 deletions
1
onnx/backend/test/data/node/test_optional_has_element_tensor/test_data_set_0/output_0.pb
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
BoutputJ |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Another test-case where
inputs=[]
orinput=['']
would be useful.How about test-cases for optional_get_element?