New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use find_namespace_packages to get needed subdirectories to silent lots of warnings #4457
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com>
jcwchen
added
build
Issues related to ONNX builds and packages
CI pipelines
Issues related to the CI pipeline
labels
Aug 18, 2022
Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com>
Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com>
jcwchen
changed the title
[WIP] Use find_namespace_packages instead of find_packages to silent lots of warnings
Use find_namespace_packages to get needed subdirectories to silent lots of warnings
Aug 24, 2022
Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com>
Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com>
gramalingam
approved these changes
Sep 14, 2022
prasanthpul
pushed a commit
that referenced
this pull request
Oct 5, 2022
…ts of warnings (#4457) * use find_namespace_packages instead of find_packages Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com> * specifiy data Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com> * specify needed dirs Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com> * fix flake8 Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com> * remove unnecessary set Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com> * fix black Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com> Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com> Signed-off-by: Prasanth Pulavarthi <prasanth.pulavarthi@microsoft.com>
prasanthpul
pushed a commit
that referenced
this pull request
Jan 26, 2023
…ts of warnings (#4457) * use find_namespace_packages instead of find_packages Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com> * specifiy data Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com> * specify needed dirs Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com> * fix flake8 Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com> * remove unnecessary set Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com> * fix black Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com> Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com> Signed-off-by: Prasanth Pulavarthi <prasanth.pulavarthi@microsoft.com>
prasanthpul
pushed a commit
that referenced
this pull request
Jan 26, 2023
…ts of warnings (#4457) * use find_namespace_packages instead of find_packages Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com> * specifiy data Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com> * specify needed dirs Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com> * fix flake8 Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com> * remove unnecessary set Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com> * fix black Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com> Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com> Signed-off-by: Prasanth Pulavarthi <prasanth.pulavarthi@microsoft.com>
broune
pushed a commit
to broune/onnx
that referenced
this pull request
May 6, 2023
…ts of warnings (onnx#4457) * use find_namespace_packages instead of find_packages Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com> * specifiy data Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com> * specify needed dirs Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com> * fix flake8 Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com> * remove unnecessary set Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com> * fix black Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com> Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
build
Issues related to ONNX builds and packages
CI pipelines
Issues related to the CI pipeline
run release CIs
Use this label to trigger release tests in CI
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Use find_namespace_packages instead of find_packages to silent lots of warnings.
Motivation and Context
Currently there is a lot of warnings about using find_packages by setuptools in CIs. Related discussion: pypa/setuptools#3340.
Warning message is like: