-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add LpPool-18 - add ceil_mode
and dilations
attributes
#4534
Conversation
Signed-off-by: p-wysocki <przemyslaw.wysocki@intel.com>
I don't see why explicit In my experience, when writing a backend, such coverage tests are very valuable, partly as a safety net but also as additional documentation / clarification. I can not see any big cost in adding such tests, except of course for the initial effort of writing them. |
Agree with @kraiskil ... adding the test-cases would be useful. |
Why not add the |
Signed-off-by: p-wysocki <przemyslaw.wysocki@intel.com>
Signed-off-by: p-wysocki <przemyslaw.wysocki@intel.com>
@kraiskil @gramalingam I'm working on both adding tests and adding |
Signed-off-by: p-wysocki <przemyslaw.wysocki@intel.com>
Signed-off-by: p-wysocki <przemyslaw.wysocki@intel.com>
Signed-off-by: p-wysocki <przemyslaw.wysocki@intel.com>
ceil_mode
attributeceil_mode
and dilations
attributes
Signed-off-by: p-wysocki <przemyslaw.wysocki@intel.com>
Signed-off-by: p-wysocki <przemyslaw.wysocki@intel.com>
* Add LpPool-18 Signed-off-by: p-wysocki <przemyslaw.wysocki@intel.com> * Rework adapter Signed-off-by: p-wysocki <przemyslaw.wysocki@intel.com> * Minor changes Signed-off-by: p-wysocki <przemyslaw.wysocki@intel.com> * Add dilations Signed-off-by: p-wysocki <przemyslaw.wysocki@intel.com> * Add shape inference tests for dilations Signed-off-by: p-wysocki <przemyslaw.wysocki@intel.com> Signed-off-by: p-wysocki <przemyslaw.wysocki@intel.com> Co-authored-by: G. Ramalingam <grama@microsoft.com>
* Add LpPool-18 Signed-off-by: p-wysocki <przemyslaw.wysocki@intel.com> * Rework adapter Signed-off-by: p-wysocki <przemyslaw.wysocki@intel.com> * Minor changes Signed-off-by: p-wysocki <przemyslaw.wysocki@intel.com> * Add dilations Signed-off-by: p-wysocki <przemyslaw.wysocki@intel.com> * Add shape inference tests for dilations Signed-off-by: p-wysocki <przemyslaw.wysocki@intel.com> Signed-off-by: p-wysocki <przemyslaw.wysocki@intel.com> Co-authored-by: G. Ramalingam <grama@microsoft.com>
Signed-off-by: p-wysocki przemyslaw.wysocki@intel.com
Description
Add
LpPool-18
, which now hasceil_mode
anddilations
attributes. Deprecateauto_pad
, like it is done in the case of AveragePool and MaxPool.Motivation and Context
Notes
ceil_mode
attribute. As far as I understand, it makes adding the attribute toceil_mode
trivial, as it is done in this PR. The same goes for thedilations
attribute.LpPool
are non-existent (there is not such a file asonnx/onnx/backend/test/case/node/lppool.py
). Is it intentional? Pooling operators seem to have a lot of common code, so maybeLpPool
is considered to be covered by tests forMaxPool
andAveragePool
. I am not sure if it is intended or an overlook.A related PR concerns removing
storage_order
attribute from the MaxPool operator: Add MaxPool-18 - removestorage_order
attribute #4533.