Fix shebang for protoc-gen-mypy.sh script #4568
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Gaetan Lepage <gaetan@glepage.com>
GaetanLepage
force-pushed
the
fix_protoc_gen_mypy_script
branch
from
25867f5
to
c5a874d
Compare
jcwchen
approved these changes
Oct 3, 2022
broune
pushed a commit
to broune/onnx
that referenced
this pull request
May 6, 2023
Signed-off-by: Gaetan Lepage <gaetan@glepage.com> Signed-off-by: Gaetan Lepage <gaetan@glepage.com> Co-authored-by: Chun-Wei Chen <jacky82226@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changed the shebang in
tools/protoc-gen-mypy.sh.infrom#!/bin/bashto#!/usr/bin/env bash.Motivation and Context
The
tools/protoc-gen-mypy.sh.infile which generates theprotoc-gen-mypy.shscript employs a shebang which assumesbashis in/bin.However, this is not the case on all unix systems.
I propose to use the
#!/usr/bin/env bashshebang instead.