Find python libs only if BUILD_ONNX_PYTHON is set to ON #4579
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ilya Lavrenov <ilya.lavrenov@intel.com>
ilya-lavrenov
force-pushed
the
onnx-python
branch
from
319d465
to
20d0e44
Compare
|
Hi team, Anything else I can help to get it merged? |
jcwchen
approved these changes
Oct 13, 2022
justinchuby
pushed a commit
to justinchuby/onnx
that referenced
this pull request
Jan 27, 2023
Signed-off-by: Ilya Lavrenov <ilya.lavrenov@intel.com> Signed-off-by: Ilya Lavrenov <ilya.lavrenov@intel.com> Co-authored-by: Chun-Wei Chen <jacky82226@gmail.com>
broune
pushed a commit
to broune/onnx
that referenced
this pull request
May 6, 2023
Signed-off-by: Ilya Lavrenov <ilya.lavrenov@intel.com> Signed-off-by: Ilya Lavrenov <ilya.lavrenov@intel.com> Co-authored-by: Chun-Wei Chen <jacky82226@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Before this change, Python Libraries are found unconditionally and several cache variables are set.
Motivation and Context
Python libraries search is not a simple algorithm and if we use
pybind11in the project, it searches libraries in a different way. This leads to a conflict, so the simple solution - don't find python libraries if they are not really needed