Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check the rest of actual input/output type if Variadic #4622

Merged
merged 3 commits into from Nov 3, 2022

Conversation

jcwchen
Copy link
Member

@jcwchen jcwchen commented Oct 25, 2022

Description

Check the rest of actual input/output type if the last input/output is Variadic

Motivation and Context

Closes #4619.

Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com>
@jcwchen jcwchen requested a review from a team as a code owner October 25, 2022 22:51
Copy link
Contributor

@gramalingam gramalingam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the fix!

@jcwchen jcwchen merged commit 76b865e into onnx:main Nov 3, 2022
@jcwchen jcwchen deleted the jcw/checker-var branch November 3, 2022 16:17
justinchuby pushed a commit to justinchuby/onnx that referenced this pull request Jan 27, 2023
Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com>

Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com>
broune pushed a commit to broune/onnx that referenced this pull request May 6, 2023
Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com>

Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[Bug] Checker misses data type mismatch for Max
3 participants