Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Output missing last new line from coverage reporter #4636

Merged
merged 2 commits into from Nov 7, 2022
Merged

Output missing last new line from coverage reporter #4636

merged 2 commits into from Nov 7, 2022

Conversation

take-cheeze
Copy link
Member

Description

tabulate function doesn't add new line to last row so it will be mixed up with next pytest summary

Motivation and Context

Without this, the pytest summary would be broken like following:

...
Tanh                   No attributes
ThresholdedRelu        alpha: 1
Tile                   No attributes
TopK                   axis: 2
                       largest: 1
                       sorted: 1
Transpose              perm: 9
Trilu                  upper: 1
Xor                    No attributes
PRelu                  No attributes============================= 1100 passed, 985 skipped, 80 xfailed, 1400 warnings in 11.72s ==============================

@take-cheeze take-cheeze requested a review from a team as a code owner November 5, 2022 00:15
jcwchen
jcwchen approved these changes Nov 5, 2022
View reviewed changes
Copy link
Member

@jcwchen jcwchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching this. Please fix DCO failure by https://github.com/onnx/onnx/blob/main/CONTRIBUTING.md#dco.

@take-cheeze
Output missing last new line from coverage reporter
dccb0f5 
Signed-off-by: take-cheeze <takechi101010@gmail.com>
@take-cheeze
Copy link
Member Author

@jcwchen Thank you for reviewing! DCO and lint should be fixed now!

@jcwchen jcwchen enabled auto-merge (squash) November 7, 2022 05:40
@jcwchen jcwchen merged commit 621119e into onnx:main Nov 7, 2022
@take-cheeze take-cheeze deleted the patch-3 branch November 7, 2022 13:54
justinchuby pushed a commit to justinchuby/onnx that referenced this pull request Jan 27, 2023
@take-cheeze @justinchuby
Output missing last new line from coverage reporter (onnx#4636)
644b7df 
Signed-off-by: take-cheeze <takechi101010@gmail.com>

Signed-off-by: take-cheeze <takechi101010@gmail.com>
broune pushed a commit to broune/onnx that referenced this pull request May 6, 2023
@take-cheeze
Output missing last new line from coverage reporter (onnx#4636)
d2109ed 
Signed-off-by: take-cheeze <takechi101010@gmail.com>

Signed-off-by: take-cheeze <takechi101010@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gramalingam gramalingam gramalingam approved these changes

@jcwchen jcwchen jcwchen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@take-cheeze @gramalingam @jcwchen