Correct types in GridSample def.cc #4655
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Liqun Fu <liqfu@microsoft.com>
|
Hi! Should I add this PR to ONNX 1.13 milestone? The CF is on 18th November. |
Signed-off-by: Liqun Fu <liqfu@microsoft.com>
Signed-off-by: Liqun Fu <liqfu@microsoft.com>
gramalingam
reviewed
Nov 14, 2022
onnx/defs/tensor/defs.cc
Outdated
| .TypeConstraint( | ||
| "T2", | ||
| {"tensor(float16)", "tensor(float)", "tensor(double)"}, | ||
| "Constrain output types to float tensors.") | ||
| "Constrain grid and output types to float tensors.") |
There was a problem hiding this comment.
Only "grid"? Not "output"?
Signed-off-by: Liqun Fu <liqfu@microsoft.com>
Signed-off-by: Liqun Fu <liqfu@microsoft.com>
gramalingam
reviewed
Nov 14, 2022
docs/Operators.md
Outdated
| @@ -9325,6 +9325,10 @@ Other versions of this operator: <a href="Changelog.md#GreaterOrEqual-12">12</a> | |||
| Given an `input` and a flow-field `grid`, computes the `output` using `input` values and pixel locations from `grid`. | |||
| Currently, only spatial (4-D) inputs are supported. For `input` with shape (N, C, H, W) and `grid` with shape (N, H_out, W_out, 2), | |||
| the `output` will have shape (N, C, H_out, W_out). | |||
|
|
|||
| Input are pixels in 2-dimensional space with each pixel as a square whose value is at the square center. | |||
There was a problem hiding this comment.
I think this should be explained better. I personally like what PR 4089 says. But as a compromise and a short summary for now, how about:
The tensor `Input` describes the value of a function (over a 2-dimensional space), or pixel, at integer coordinates.
The tensor `grid` describes the grid-positions where the function-value is to be computed using a specified
interpolation method (the mode) and a padding mode (for grid positions falling outside the dimensions of `input`)
There was a problem hiding this comment.
May be contains would be better than describes in above.
There was a problem hiding this comment.
So, something like
The tensor `Input` contains the pixel-values at integer-coordinates. The tensor `grid` describes the grid-positions
(using floating-values) where the pixel-value is to be computed using ... etc. (as above).
Signed-off-by: Liqun Fu <liqfu@microsoft.com>
Signed-off-by: Liqun Fu <liqfu@microsoft.com>
Signed-off-by: Liqun Fu <liqfu@microsoft.com>
gramalingam
reviewed
Nov 14, 2022
gramalingam
approved these changes
Nov 14, 2022
Signed-off-by: Liqun Fu <liqfu@microsoft.com>
justinchuby
pushed a commit
to justinchuby/onnx
that referenced
this pull request
Jan 27, 2023
broune
pushed a commit
to broune/onnx
that referenced
this pull request
May 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
type specified for GridSample is incorrect
Motivation and Context
fix the error