Bump release version to 1.13 #4666
Conversation
Signed-off-by: p-wysocki <przemyslaw.wysocki@intel.com>
There was a problem hiding this comment.
The PR itself looks good to me. Will approve it after code freeze. Thank you @p-wysocki for driving ONNX 1.13 release!
| @@ -7,6 +7,6 @@ | |||
| namespace ONNX_NAMESPACE { | |||
|
|
|||
| // Represents the most recent release version. Updated with every release. | |||
| constexpr const char* LAST_RELEASE_VERSION = "1.12.0"; | |||
| constexpr const char* LAST_RELEASE_VERSION = "1.13.0"; | |||
There was a problem hiding this comment.
1.13.0rc1
we shall make it 1.13.0 when the release is validated
There was a problem hiding this comment.
This PR is bumping version number in the main branch first and so I think 1.13.0 is correct here. See old releases: #3973, #4209.
By contrast, the release manager will further cut the release branch and then manually change the version number in https://github.com/onnx/onnx/blob/main/VERSION_NUMBER with XXXrc1.
There was a problem hiding this comment.
also need to make change to https://github.com/onnx/onnx/blob/main/VERSION_NUMBER
|
@liqunfu Do you mean https://github.com/onnx/onnx/pull/4666/files#diff-22aa3cdc2dc9bec750e99a529ea7ac3d2642c71212cb3d8843265916ea7ffc18L1? That file has been changed. |
Signed-off-by: p-wysocki <przemyslaw.wysocki@intel.com> Signed-off-by: p-wysocki <przemyslaw.wysocki@intel.com> Co-authored-by: G. Ramalingam <grama@microsoft.com>
Signed-off-by: p-wysocki <przemyslaw.wysocki@intel.com> Signed-off-by: p-wysocki <przemyslaw.wysocki@intel.com> Co-authored-by: G. Ramalingam <grama@microsoft.com>
Signed-off-by: p-wysocki przemyslaw.wysocki@intel.com
Description
PR is a part of an ongoing 1.13.0 release. It's based on #4209.