[1.13.1rc2] More cherry picks for fixing function shape inference #4886
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e inference (onnx#4792) * Fix attribute substitution within subgraphs in function inference Signed-off-by: Ganesan Ramalingam <grama@microsoft.com> * Delete commented out dead code Signed-off-by: Ganesan Ramalingam <grama@microsoft.com> * Address PR feedback Signed-off-by: Ganesan Ramalingam <grama@microsoft.com> * Fix lint issue Signed-off-by: Ganesan Ramalingam <grama@microsoft.com> Signed-off-by: Ganesan Ramalingam <grama@microsoft.com> Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com>
* Fix attribute substitution within subgraphs in function inference Signed-off-by: Ganesan Ramalingam <grama@microsoft.com> * Delete commented out dead code Signed-off-by: Ganesan Ramalingam <grama@microsoft.com> * Address PR feedback Signed-off-by: Ganesan Ramalingam <grama@microsoft.com> * Fix lint issue Signed-off-by: Ganesan Ramalingam <grama@microsoft.com> * Handle constant op variants Signed-off-by: Ganesan Ramalingam <grama@microsoft.com> * Fix whitespace Signed-off-by: Ganesan Ramalingam <grama@microsoft.com> * Add test case Signed-off-by: Ganesan Ramalingam <grama@microsoft.com> * Run lintrunner Signed-off-by: Ganesan Ramalingam <grama@microsoft.com> --------- Signed-off-by: Ganesan Ramalingam <grama@microsoft.com> Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com>
Signed-off-by: Ganesan Ramalingam <grama@microsoft.com> Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com>
* Fix function shape inference bug Signed-off-by: Ganesan Ramalingam <grama@microsoft.com> * Fix lintrunner issues Signed-off-by: Ganesan Ramalingam <grama@microsoft.com> --------- Signed-off-by: Ganesan Ramalingam <grama@microsoft.com> Co-authored-by: Chun-Wei Chen <jacky82226@gmail.com> Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com>
Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com>
gramalingam
approved these changes
Feb 10, 2023
Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com>
jcwchen
commented
Feb 13, 2023
Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Motivation and Context
To include more shape inference fixes for onnx-script.