Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix type constraints of Reshape(19) #5146

Merged
merged 2 commits into from Apr 17, 2023
Merged

Fix type constraints of Reshape(19) #5146

merged 2 commits into from Apr 17, 2023

Conversation

xadupre
Copy link
Contributor

@xadupre xadupre commented Apr 17, 2023

Description

Fix a wrong renaming introduced in PR #5123. Float 8 types were missing from Reshape allowed types.

@xadupre
Fix type constraints of Reshape(19)
573fb2b 
Signed-off-by: xadupre <xadupre@microsoft.com>
@xadupre xadupre requested a review from a team as a code owner April 17, 2023 17:17
@jcwchen jcwchen added this to the 1.14.0 milestone Apr 17, 2023
@jcwchen jcwchen added shape inference Issues related to shape inference run release CIs Use this label to trigger release tests in CI labels Apr 17, 2023
gramalingam
gramalingam approved these changes Apr 17, 2023
View reviewed changes
Copy link
Contributor

@gramalingam gramalingam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor nit: I guess the "doc" string can be shared by old and new defs since they are identical by moving it to utils.h/utils.cc. And renaming it to something appropriate like Reshape_ver14_and_ver19_doc. Helps when somebody is browsing the code.

jcwchen
jcwchen approved these changes Apr 17, 2023
View reviewed changes
Copy link
Member

@jcwchen jcwchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc release manager @yuanyao-nv

@xadupre
Copy link
Contributor Author

xadupre commented Apr 17, 2023

I suggest keeping it that way for this release and let us take time to think about a mechanism to avoid duplication in documentation.

@xadupre xadupre enabled auto-merge (squash) April 17, 2023 19:41
@xadupre xadupre merged commit 3f4140a into onnx:main Apr 17, 2023
63 checks passed
@jcwchen
Copy link
Member

jcwchen commented Apr 20, 2023

I suggest keeping it that way for this release and let us take time to think about a mechanism to avoid duplication in documentation.

P.S. Tracked by this #4138.

yuanyao-nv pushed a commit to yuanyao-nv/onnx that referenced this pull request Apr 26, 2023
@xadupre @yuanyao-nv
Fix type constraints of Reshape(19) (onnx#5146)
e1fc0ba 
Signed-off-by: xadupre <xadupre@microsoft.com>
Signed-off-by: Yuan Yao <yuanyao@nvidia.com>
@yuanyao-nv yuanyao-nv mentioned this pull request Apr 26, 2023
Merged
yuanyao-nv pushed a commit that referenced this pull request Apr 26, 2023
@xadupre @yuanyao-nv
Fix type constraints of Reshape(19) (#5146)
8892e7d 
Signed-off-by: xadupre <xadupre@microsoft.com>
Signed-off-by: Yuan Yao <yuanyao@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gramalingam gramalingam gramalingam approved these changes

@jcwchen jcwchen jcwchen approved these changes

Assignees
No one assigned
Labels
run release CIs Use this label to trigger release tests in CI shape inference Issues related to shape inference
Projects
PR Tracker
Status: Done
Milestone
1.14.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@xadupre @jcwchen @gramalingam