-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
correct averagepool kernel shape in dilation test case #5158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Liqun Fu <liqfu@microsoft.com>
Signed-off-by: Liqun Fu <liqfu@microsoft.com>
Signed-off-by: Liqun Fu <liqfu@microsoft.com>
jcwchen
reviewed
Apr 20, 2023
Signed-off-by: Liqun Fu <liqfu@microsoft.com>
gramalingam
reviewed
Apr 20, 2023
jcwchen
approved these changes
Apr 24, 2023
Signed-off-by: Liqun Fu <liqfu@microsoft.com>
…//github.com/onnx/onnx into liqun/correct_average_pool_test_kernel_shape
jcwchen
reviewed
Apr 25, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's expediate this PR for cherry-pick. Operators.md will need to be updated as well. Thanks!
xadupre
reviewed
Apr 25, 2023
gramalingam
approved these changes
Apr 25, 2023
yuanyao-nv
pushed a commit
to yuanyao-nv/onnx
that referenced
this pull request
Apr 26, 2023
Signed-off-by: Yuan Yao <yuanyao@nvidia.com>
yuanyao-nv
pushed a commit
that referenced
this pull request
Apr 26, 2023
Signed-off-by: Yuan Yao <yuanyao@nvidia.com>
adityagoel4512
pushed a commit
to adityagoel4512/onnx
that referenced
this pull request
Jul 28, 2023
Signed-off-by: Aditya Goel <agoel4512@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
kernel shape is incorrect with test case: test_averagepool_2d_dilations
Motivation and Context
correct kernel shape