Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

correct averagepool kernel shape in dilation test case #5158

Merged
merged 13 commits into from
Apr 25, 2023

Conversation

liqunfu
Copy link
Contributor

@liqunfu liqunfu commented Apr 20, 2023

Description

kernel shape is incorrect with test case: test_averagepool_2d_dilations

Motivation and Context

correct kernel shape

Signed-off-by: Liqun Fu <liqfu@microsoft.com>
@liqunfu liqunfu added this to the 1.14.0 milestone Apr 20, 2023
@liqunfu liqunfu requested a review from a team as a code owner April 20, 2023 01:14
@jcwchen jcwchen added the test label Apr 20, 2023
Signed-off-by: Liqun Fu <liqfu@microsoft.com>
Signed-off-by: Liqun Fu <liqfu@microsoft.com>
@liqunfu liqunfu requested a review from a team as a code owner April 20, 2023 04:44
Signed-off-by: Liqun Fu <liqfu@microsoft.com>
onnx/defs/nn/defs.cc Outdated Show resolved Hide resolved
onnx/test/reference_evaluator_backend_test.py Show resolved Hide resolved
Signed-off-by: Liqun Fu <liqfu@microsoft.com>
Signed-off-by: Liqun Fu <liqfu@microsoft.com>
Copy link
Member

@jcwchen jcwchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's expediate this PR for cherry-pick. Operators.md will need to be updated as well. Thanks!

Signed-off-by: Liqun Fu <liqfu@microsoft.com>
@liqunfu liqunfu enabled auto-merge (squash) April 25, 2023 20:41
@liqunfu liqunfu merged commit b8ffabf into main Apr 25, 2023
38 checks passed
@liqunfu liqunfu deleted the liqun/correct_average_pool_test_kernel_shape branch April 25, 2023 21:27
yuanyao-nv pushed a commit to yuanyao-nv/onnx that referenced this pull request Apr 26, 2023
Signed-off-by: Yuan Yao <yuanyao@nvidia.com>
yuanyao-nv pushed a commit that referenced this pull request Apr 26, 2023
Signed-off-by: Yuan Yao <yuanyao@nvidia.com>
adityagoel4512 pushed a commit to adityagoel4512/onnx that referenced this pull request Jul 28, 2023
Signed-off-by: Aditya Goel <agoel4512@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

4 participants