Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add FP8, BF16 to ConstantOfShape #5390

Merged
merged 3 commits into from
Jul 4, 2023
Merged

Add FP8, BF16 to ConstantOfShape #5390

merged 3 commits into from
Jul 4, 2023

Conversation

yuanyao-nv
Copy link
Contributor

@yuanyao-nv yuanyao-nv commented Jul 3, 2023 •
edited
Loading

Description

The original FP8 seems to have missed enabling FP8 and BF16 data types for ConstantOfShape.

Motivation and Context

@yuanyao-nv
add fp8 to ConstantOfShape
f3a79f7 
Signed-off-by: Yuan Yao <yuanyao@nvidia.com>
@yuanyao-nv yuanyao-nv requested a review from a team as a code owner July 3, 2023 18:27
@yuanyao-nv
also add BF16
3e81c4a 
Signed-off-by: Yuan Yao <yuanyao@nvidia.com>
@yuanyao-nv yuanyao-nv changed the title Add FP8 to ConstantOfShape Add FP8, BF16 to ConstantOfShape Jul 3, 2023
@yuanyao-nv
fix test
efe113e 
Signed-off-by: Yuan Yao <yuanyao@nvidia.com>
@yuanyao-nv yuanyao-nv requested a review from a team as a code owner July 4, 2023 00:58
@xadupre xadupre merged commit 60efa04 into onnx:main Jul 4, 2023
37 checks passed
@jcwchen jcwchen added the schema Issues related to operator schemas label Jul 5, 2023
@jcwchen jcwchen mentioned this pull request Jul 7, 2023
Merged
pranshupant added a commit to pranshupant/onnx that referenced this pull request Jul 8, 2023
@pranshupant
Updated Changelog to account for onnx#5390
00b977f 
Signed-off-by: pranshupant <pranshupant@gmail.com>
adityagoel4512 added a commit to adityagoel4512/onnx that referenced this pull request Jul 15, 2023
@adityagoel4512
Add FP8, BF16 to ConstantOfShape (onnx#5390)
89742e3 
The original FP8 seems to have missed enabling FP8 and BF16 data types
for `ConstantOfShape`.

<!-- - Why is this change required? What problem does it solve? -->
<!-- - If it fixes an open issue, please link to the issue here. -->

---------

Signed-off-by: Yuan Yao <yuanyao@nvidia.com>
Signed-off-by: Aditya Goel <agoel4512@gmail.com>
adityagoel4512 pushed a commit to adityagoel4512/onnx that referenced this pull request Jul 28, 2023
@yuanyao-nv @adityagoel4512
Add FP8, BF16 to ConstantOfShape (onnx#5390)
452b75b 
The original FP8 seems to have missed enabling FP8 and BF16 data types
for `ConstantOfShape`.

<!-- - Why is this change required? What problem does it solve? -->
<!-- - If it fixes an open issue, please link to the issue here. -->

---------

Signed-off-by: Yuan Yao <yuanyao@nvidia.com>
adityagoel4512 added a commit to adityagoel4512/onnx that referenced this pull request Jul 28, 2023
@adityagoel4512
Add FP8, BF16 to ConstantOfShape (onnx#5390)
b0113c4 
The original FP8 seems to have missed enabling FP8 and BF16 data types
for `ConstantOfShape`.

<!-- - Why is this change required? What problem does it solve? -->
<!-- - If it fixes an open issue, please link to the issue here. -->

---------

Signed-off-by: Yuan Yao <yuanyao@nvidia.com>
Signed-off-by: Aditya Goel <agoel4512@gmail.com>
adityagoel4512 pushed a commit to adityagoel4512/onnx that referenced this pull request Jul 28, 2023
@yuanyao-nv @adityagoel4512
Add FP8, BF16 to ConstantOfShape (onnx#5390)
6a3c36f 
The original FP8 seems to have missed enabling FP8 and BF16 data types
for `ConstantOfShape`.

<!-- - Why is this change required? What problem does it solve? -->
<!-- - If it fixes an open issue, please link to the issue here. -->

---------

Signed-off-by: Yuan Yao <yuanyao@nvidia.com>
Signed-off-by: Aditya Goel <agoel4512@gmail.com>
adityagoel4512 added a commit to adityagoel4512/onnx that referenced this pull request Jul 28, 2023
@adityagoel4512
Add FP8, BF16 to ConstantOfShape (onnx#5390)
d997648 
The original FP8 seems to have missed enabling FP8 and BF16 data types
for `ConstantOfShape`.

<!-- - Why is this change required? What problem does it solve? -->
<!-- - If it fixes an open issue, please link to the issue here. -->

---------

Signed-off-by: Yuan Yao <yuanyao@nvidia.com>
Signed-off-by: Aditya Goel <agoel4512@gmail.com>
adityagoel4512 pushed a commit to adityagoel4512/onnx that referenced this pull request Jul 28, 2023
@yuanyao-nv @adityagoel4512
Add FP8, BF16 to ConstantOfShape (onnx#5390)
fb1fb23 
The original FP8 seems to have missed enabling FP8 and BF16 data types
for `ConstantOfShape`.

<!-- - Why is this change required? What problem does it solve? -->
<!-- - If it fixes an open issue, please link to the issue here. -->

---------

Signed-off-by: Yuan Yao <yuanyao@nvidia.com>
adityagoel4512 added a commit to adityagoel4512/onnx that referenced this pull request Jul 28, 2023
@adityagoel4512
Add FP8, BF16 to ConstantOfShape (onnx#5390)
1addef0 
The original FP8 seems to have missed enabling FP8 and BF16 data types
for `ConstantOfShape`.

<!-- - Why is this change required? What problem does it solve? -->
<!-- - If it fixes an open issue, please link to the issue here. -->

---------

Signed-off-by: Yuan Yao <yuanyao@nvidia.com>
Signed-off-by: Aditya Goel <agoel4512@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xadupre xadupre xadupre approved these changes

Assignees
No one assigned
Labels
schema Issues related to operator schemas
Projects
PR Tracker
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@yuanyao-nv @xadupre @jcwchen