adding tests for cast operation #543
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Feb 21, 2018
|
@bddppq , @houseroad : please feel free to review this PR instead of earlier PR on cast operator tests. |
|
✅ Build onnx 0.3.1290 completed (commit 75cb369816 by @houseroad) |
houseroad
approved these changes
Feb 26, 2018
houseroad
reviewed
Feb 27, 2018
onnx/backend/test/case/node/cast.py
Outdated
| for case in test_cases: | ||
| from_type = case[0] | ||
| to_type = case[1] | ||
| input = np.random.random_sample(shape).astype(type_map[getattr(TensorProto, from_type)]) |
There was a problem hiding this comment.
In the generated doc, user may be confused about the type_map. If we put TENSOR_TYPE_TO_NP_TYPE here directly, it will be clear to users.
There was a problem hiding this comment.
Sure, pushed an update.
|
@onnxbot test this please |
Closed
Ac2zoom
pushed a commit
to Ac2zoom/onnx
that referenced
this pull request
Jun 21, 2018
* adding tests for cast operation * addressing PR feedback
jcwchen
pushed a commit
to jcwchen/onnx
that referenced
this pull request
Sep 23, 2020
* adding tests for cast operation * addressing PR feedback
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.