-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add github action to check urls are valid #5434
Conversation
Signed-off-by: Xavier Dupre <xadupre@microsoft.com>
Signed-off-by: Xavier Dupre <xadupre@microsoft.com>
I didn't see it running in this pr. Do we need to configure triggers? |
Signed-off-by: Xavier Dupre <xadupre@microsoft.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the update -- now this added CI was triggered in this PR, but according to the log, the CI did not fail when it found some invalid URLs.
Co-authored-by: Chun-Wei Chen <jacky82226@gmail.com> Signed-off-by: Xavier Dupré <xadupre@users.noreply.github.com>
Co-authored-by: Chun-Wei Chen <jacky82226@gmail.com> Signed-off-by: Xavier Dupré <xadupre@users.noreply.github.com>
Co-authored-by: Chun-Wei Chen <jacky82226@gmail.com> Signed-off-by: Xavier Dupré <xadupre@users.noreply.github.com>
Co-authored-by: Chun-Wei Chen <jacky82226@gmail.com> Signed-off-by: Xavier Dupré <xadupre@users.noreply.github.com>
@gramalingam for approval |
@onnx/sig-operators-approvers for approval |
Signed-off-by: Justin Chu <justinchuby@users.noreply.github.com>
Signed-off-by: Justin Chu <justinchuby@users.noreply.github.com>
Description
This action checks that urls in the code or in the documentation are valid.
Motivation and Context
It avoids having broken urls.