Change the cached model checking logic #545
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Feb 21, 2018
prasanthpul
approved these changes
Feb 21, 2018
anderspapitto
approved these changes
Feb 21, 2018
bddppq
reviewed
Feb 22, 2018
onnx/backend/test/runner/__init__.py
Outdated
| if not os.path.exists(model_dir): | ||
| if not os.path.exists(os.path.join(model_dir, 'model.onnx')): | ||
| if os.path.exists(model_dir): | ||
| shutil.rmtree(model_dir) |
There was a problem hiding this comment.
Better to not delete user's files, move it to say ~/.onnx/models/squeezenet.old.1 (or .2 if .1 already exists)
There was a problem hiding this comment.
Now move it as .old.0, old.1, etc...
Closed
Ac2zoom
pushed a commit
to Ac2zoom/onnx
that referenced
this pull request
Jun 21, 2018
* Change the cached model checking logic * Move the old folder, instead of deleting
jcwchen
pushed a commit
to jcwchen/onnx
that referenced
this pull request
Sep 23, 2020
* Change the cached model checking logic * Move the old folder, instead of deleting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we change the file extension from .pb to .onnx, we should not keep the old cached files.