Fix Slice shape inference in the case of dynamic inputs #5475
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested review from
jcwchen
approved these changes
Aug 7, 2023
There was a problem hiding this comment.
It should be worthy to fix the same issue in Slice-11 and Slice-10 as well?
Lines 1050 to 1053 in 025a911
|
@onnx/sig-operators-approvers for approval |
|
Could you fix dco by signing the new commit? |
Signed-off-by: Atanas Dimitrov <atanas.dimitrov@quantco.com>
|
@justinchuby could we please add this to the merge queue? |
|
We need an additional approval from @onnx/sig-operators-approvers |
gramalingam
reviewed
Aug 17, 2023
| @@ -958,6 +958,11 @@ ONNX_OPERATOR_SET_SCHEMA( | |||
|
|
|||
| if (!startsInitializer || !endsInitializer || (hasInputShape(ctx, 3) && !ctx.getInputData(3)) || | |||
| (hasInputShape(ctx, 4) && !ctx.getInputData(4))) { | |||
| const auto input_rank = ctx.getInputType(0)->tensor_type().shape().dim_size(); | |||
There was a problem hiding this comment.
This looks good, thanks! Unrelated to this change, I wonder if we should change the hasInputShape in the previous two lines to hasInput? We need to only check if the starts/ends inputs are supplied, not whether we know their shape.
gramalingam
approved these changes
Aug 17, 2023
Signed-off-by: Justin Chu <justinchuby@users.noreply.github.com>
Signed-off-by: Justin Chu <justinchuby@users.noreply.github.com>
Signed-off-by: Justin Chu <justinchuby@users.noreply.github.com>
corwinjoy
pushed a commit
to corwinjoy/onnx
that referenced
this pull request
Sep 5, 2023
### Description Slice shape-inference didn't work when the start or stop inputs were not defined. ### Motivation and Context This contributes to making the type and shape inference more complete. --------- Signed-off-by: Atanas Dimitrov <atanas.dimitrov@quantco.com> Signed-off-by: Justin Chu <justinchuby@users.noreply.github.com> Co-authored-by: Justin Chu <justinchuby@users.noreply.github.com> Signed-off-by: Corwin Joy <corwinjoy@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Slice shape-inference didn't work when the start or stop inputs were not defined.
Motivation and Context
This contributes to making the type and shape inference more complete.