Use frozen NumPy array for ImageDecoder backend test if no Pillow #5511
Conversation
…opencv-python Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com>
Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com>
|
Can we use smaller images? Make just a few pixels? |
|
@jcwchen validated this branch fixes the underlying issue. |
Co-authored-by: Aditya Goel <48102515+adityagoel4512@users.noreply.github.com> Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com>
There was a problem hiding this comment.
Can we use smaller images? Make just a few pixels?
Good question. Now by default generate_test_data is using 40x40, which is sort of in the middle, but I don't have proper number in mind. Ideally the size of image should be large enough for runtime to test. @jantonguirao do you think it's a good idea to shrink the test image a bit?
@lutzroeder Great! Thank you for the validation. |
|
@jcwchen We could reduce the image size to something like 32x32, but I wouldn't go much smaller than that. |
Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com>
Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com>
…into jcw/freeze-cv2-input
Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com>
jcwchen
changed the title
Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com>
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
There was a problem hiding this comment.
@jcwchen We could reduce the image size to something like 32x32, but I wouldn't go much smaller than that.
Thank you for the suggestion! I have used 32x32 instead of 40x40 and now the used lines in that Python file was reduced from 35637 lines to 23,604 lines.
Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com>
|
The proposal seems rather complex to me. Why not using pillow instead of opencv? |
Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com>
|
As @justinchuby suggested, I turned off black formatter for image_decoder_data.py and rearranged those large NumPy arrays. Now the code lines was decreased from 23,604 to 5,134, which is now previewable in this PR. @onnx/sig-operators-approvers PTAL. Thanks! |
jcwchen
added
the
review needed: operators approvers
|
Would be nice to wait for #5555 because there are slight changes in values |
jcwchen
changed the title
Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com> # Conflicts: # docs/Operators.md # docs/TestCoverage.md # onnx/backend/test/case/node/image_decoder.py # onnx/backend/test/data/node/test_image_decoder_decode_bmp_rgb/test_data_set_0/input_0.pb # onnx/backend/test/data/node/test_image_decoder_decode_jpeg2k_rgb/model.onnx # onnx/backend/test/data/node/test_image_decoder_decode_jpeg2k_rgb/test_data_set_0/input_0.pb # onnx/backend/test/data/node/test_image_decoder_decode_jpeg2k_rgb/test_data_set_0/output_0.pb # onnx/backend/test/data/node/test_image_decoder_decode_jpeg_bgr/model.onnx # onnx/backend/test/data/node/test_image_decoder_decode_jpeg_bgr/test_data_set_0/input_0.pb # onnx/backend/test/data/node/test_image_decoder_decode_jpeg_bgr/test_data_set_0/output_0.pb # onnx/backend/test/data/node/test_image_decoder_decode_jpeg_grayscale/model.onnx # onnx/backend/test/data/node/test_image_decoder_decode_jpeg_grayscale/test_data_set_0/input_0.pb # onnx/backend/test/data/node/test_image_decoder_decode_jpeg_grayscale/test_data_set_0/output_0.pb # onnx/backend/test/data/node/test_image_decoder_decode_jpeg_rgb/model.onnx # onnx/backend/test/data/node/test_image_decoder_decode_jpeg_rgb/test_data_set_0/input_0.pb # onnx/backend/test/data/node/test_image_decoder_decode_jpeg_rgb/test_data_set_0/output_0.pb # onnx/backend/test/data/node/test_image_decoder_decode_png_rgb/model.onnx # onnx/backend/test/data/node/test_image_decoder_decode_png_rgb/test_data_set_0/input_0.pb # onnx/backend/test/data/node/test_image_decoder_decode_tiff_rgb/model.onnx # onnx/backend/test/data/node/test_image_decoder_decode_tiff_rgb/test_data_set_0/input_0.pb # onnx/backend/test/data/node/test_image_decoder_decode_webp_rgb/model.onnx # onnx/backend/test/data/node/test_image_decoder_decode_webp_rgb/test_data_set_0/input_0.pb # onnx/backend/test/data/node/test_image_decoder_decode_webp_rgb/test_data_set_0/output_0.pb
justinchuby
removed
the
review needed: operators approvers
…into jcw/freeze-cv2-input
jcwchen
changed the title
Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com>
Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com>
Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com>
jcwchen
changed the title
|
I have updated _image_decoder_data.py accordingly with the new data from #5555 (created from Pillow). Also CI pipeline will test with/without pillow with node test generation. If no one has other concern for this PR, I will forward this PR by the end of today. Thank you all for the reviews! |
Description
Motivation and Context
Similar to #5498. Hopefully this PR can entirely fix #5491.
Ideally test generation should be as simple as possible without other new dependency especially that dependency was not used in other places (reference will only use pillow when needed). Let's merge this PR first and later I will have another PR to freeze input/output as a pure NumPy array and simply keep generate_checkerboard/generate_test_data for future reference.