Specify the build-system in pyproject.toml #5531
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Justin Chu <justinchu@microsoft.com>
jcwchen
approved these changes
Aug 26, 2023
There was a problem hiding this comment.
Another option: adding setuptools>=61.0.0 directly in https://github.com/onnx/onnx/blob/main/requirements.txt? but I also feel adding it in pyproject.toml seems more proper.
|
It doesn’t need to be in requirements because it’s a build time dependency not a runtime one |
jcwchen
reviewed
Aug 28, 2023
There was a problem hiding this comment.
CI for uploading onnx-weekly seems failed because of this PR: https://github.com/onnx/onnx/actions/runs/5993960831/job/16254965073.
|
Hmm. Looks like more things need to be fixed. I will revert |
justinchuby
added a commit
that referenced
this pull request
Aug 28, 2023
This reverts commit b8482d7.
github-merge-queue bot
pushed a commit
that referenced
this pull request
Aug 28, 2023
Reverts #5531 because the macos release pipeline is broken due to the change.
github-merge-queue bot
pushed a commit
that referenced
this pull request
Aug 28, 2023
### Description Specify setuptools in the build-system section in pyproject.toml. So that setuptools gets installed when it is not in the environment when doing local install. Second attempt of #5531 by removing `--no-use-pep517` in the test pipeline ### Motivation and Context Fixes #4878 --------- Signed-off-by: Justin Chu <justinchu@microsoft.com>
corwinjoy
pushed a commit
to corwinjoy/onnx
that referenced
this pull request
Sep 5, 2023
### Description Specify setuptools in the build-system section in pyproject.toml. So that setuptools gets installed when it is not in the environment when doing local install. ### Motivation and Context Fixes onnx#4878 Signed-off-by: Justin Chu <justinchu@microsoft.com> Signed-off-by: Corwin Joy <corwinjoy@gmail.com>
corwinjoy
pushed a commit
to corwinjoy/onnx
that referenced
this pull request
Sep 5, 2023
Reverts onnx#5531 because the macos release pipeline is broken due to the change. Signed-off-by: Corwin Joy <corwinjoy@gmail.com>
corwinjoy
pushed a commit
to corwinjoy/onnx
that referenced
this pull request
Sep 5, 2023
### Description Specify setuptools in the build-system section in pyproject.toml. So that setuptools gets installed when it is not in the environment when doing local install. Second attempt of onnx#5531 by removing `--no-use-pep517` in the test pipeline ### Motivation and Context Fixes onnx#4878 --------- Signed-off-by: Justin Chu <justinchu@microsoft.com> Signed-off-by: Corwin Joy <corwinjoy@gmail.com>
corwinjoy
pushed a commit
to corwinjoy/onnx
that referenced
this pull request
Sep 5, 2023
### Description Specify setuptools in the build-system section in pyproject.toml. So that setuptools gets installed when it is not in the environment when doing local install. ### Motivation and Context Fixes onnx#4878 Signed-off-by: Justin Chu <justinchu@microsoft.com> Signed-off-by: Corwin Joy <corwinjoy@gmail.com>
corwinjoy
pushed a commit
to corwinjoy/onnx
that referenced
this pull request
Sep 5, 2023
Reverts onnx#5531 because the macos release pipeline is broken due to the change. Signed-off-by: Corwin Joy <corwinjoy@gmail.com>
corwinjoy
pushed a commit
to corwinjoy/onnx
that referenced
this pull request
Sep 5, 2023
### Description Specify setuptools in the build-system section in pyproject.toml. So that setuptools gets installed when it is not in the environment when doing local install. Second attempt of onnx#5531 by removing `--no-use-pep517` in the test pipeline ### Motivation and Context Fixes onnx#4878 --------- Signed-off-by: Justin Chu <justinchu@microsoft.com> Signed-off-by: Corwin Joy <corwinjoy@gmail.com>
corwinjoy
pushed a commit
to corwinjoy/onnx
that referenced
this pull request
Sep 5, 2023
Reverts onnx#5531 because the macos release pipeline is broken due to the change. Signed-off-by: Corwin Joy <corwinjoy@gmail.com>
corwinjoy
pushed a commit
to corwinjoy/onnx
that referenced
this pull request
Sep 5, 2023
### Description Specify setuptools in the build-system section in pyproject.toml. So that setuptools gets installed when it is not in the environment when doing local install. Second attempt of onnx#5531 by removing `--no-use-pep517` in the test pipeline ### Motivation and Context Fixes onnx#4878 --------- Signed-off-by: Justin Chu <justinchu@microsoft.com> Signed-off-by: Corwin Joy <corwinjoy@gmail.com>
corwinjoy
pushed a commit
to corwinjoy/onnx
that referenced
this pull request
Sep 5, 2023
### Description Specify setuptools in the build-system section in pyproject.toml. So that setuptools gets installed when it is not in the environment when doing local install. ### Motivation and Context Fixes onnx#4878 Signed-off-by: Justin Chu <justinchu@microsoft.com> Signed-off-by: Corwin Joy <corwinjoy@gmail.com>
corwinjoy
pushed a commit
to corwinjoy/onnx
that referenced
this pull request
Sep 5, 2023
Reverts onnx#5531 because the macos release pipeline is broken due to the change. Signed-off-by: Corwin Joy <corwinjoy@gmail.com>
corwinjoy
pushed a commit
to corwinjoy/onnx
that referenced
this pull request
Sep 5, 2023
### Description Specify setuptools in the build-system section in pyproject.toml. So that setuptools gets installed when it is not in the environment when doing local install. Second attempt of onnx#5531 by removing `--no-use-pep517` in the test pipeline ### Motivation and Context Fixes onnx#4878 --------- Signed-off-by: Justin Chu <justinchu@microsoft.com> Signed-off-by: Corwin Joy <corwinjoy@gmail.com>
corwinjoy
pushed a commit
to corwinjoy/onnx
that referenced
this pull request
Sep 5, 2023
Reverts onnx#5531 because the macos release pipeline is broken due to the change. Signed-off-by: Corwin Joy <corwinjoy@gmail.com>
corwinjoy
pushed a commit
to corwinjoy/onnx
that referenced
this pull request
Sep 5, 2023
### Description Specify setuptools in the build-system section in pyproject.toml. So that setuptools gets installed when it is not in the environment when doing local install. Second attempt of onnx#5531 by removing `--no-use-pep517` in the test pipeline ### Motivation and Context Fixes onnx#4878 --------- Signed-off-by: Justin Chu <justinchu@microsoft.com> Signed-off-by: Corwin Joy <corwinjoy@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Specify setuptools in the build-system section in pyproject.toml. So that setuptools gets installed when it is not in the environment when doing local install.
Motivation and Context
Fixes #4878