-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove deprecated functions in schema.h #5538
Merged
justinchuby
merged 2 commits into
onnx:main
from
justinchuby:justinchu/deprecated-schema
Sep 1, 2023
Merged
Remove deprecated functions in schema.h #5538
justinchuby
merged 2 commits into
onnx:main
from
justinchuby:justinchu/deprecated-schema
Sep 1, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
66c2839
to
2752ec4
Compare
Signed-off-by: Justin Chu <justinchu@microsoft.com>
2752ec4
to
770c830
Compare
jcwchen
approved these changes
Aug 31, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for removing them!
xadupre
approved these changes
Sep 1, 2023
corwinjoy
pushed a commit
to corwinjoy/onnx
that referenced
this pull request
Sep 5, 2023
### Description Remove deprecated functions in schema.h that are marked for deletion in 1.15 Signed-off-by: Justin Chu <justinchu@microsoft.com> Signed-off-by: Corwin Joy <corwinjoy@gmail.com>
corwinjoy
pushed a commit
to corwinjoy/onnx
that referenced
this pull request
Sep 5, 2023
### Description Remove deprecated functions in schema.h that are marked for deletion in 1.15 Signed-off-by: Justin Chu <justinchu@microsoft.com> Signed-off-by: Corwin Joy <corwinjoy@gmail.com>
corwinjoy
pushed a commit
to corwinjoy/onnx
that referenced
this pull request
Sep 5, 2023
### Description Remove deprecated functions in schema.h that are marked for deletion in 1.15 Signed-off-by: Justin Chu <justinchu@microsoft.com> Signed-off-by: Corwin Joy <corwinjoy@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
review needed: operators approvers
Require reviews from members of operators-approvers
schema
Issues related to operator schemas
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Remove deprecated functions in schema.h that are marked for deletion in 1.15