Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated functions in schema.h #5538

Merged
merged 2 commits into from
Sep 1, 2023

Conversation

justinchuby
Copy link
Contributor

Description

Remove deprecated functions in schema.h that are marked for deletion in 1.15

@justinchuby justinchuby requested a review from a team as a code owner August 29, 2023 00:14
@justinchuby justinchuby added this to the 1.15 milestone Aug 29, 2023
Signed-off-by: Justin Chu <justinchu@microsoft.com>
Copy link
Member

@jcwchen jcwchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for removing them!

@jcwchen jcwchen added the schema Issues related to operator schemas label Aug 31, 2023
@justinchuby justinchuby added the review needed: operators approvers Require reviews from members of operators-approvers label Sep 1, 2023
@justinchuby justinchuby added this pull request to the merge queue Sep 1, 2023
Merged via the queue into onnx:main with commit 9705639 Sep 1, 2023
34 checks passed
@justinchuby justinchuby deleted the justinchu/deprecated-schema branch September 1, 2023 07:43
corwinjoy pushed a commit to corwinjoy/onnx that referenced this pull request Sep 5, 2023
### Description

Remove deprecated functions in schema.h that are marked for deletion in
1.15

Signed-off-by: Justin Chu <justinchu@microsoft.com>
Signed-off-by: Corwin Joy <corwinjoy@gmail.com>
corwinjoy pushed a commit to corwinjoy/onnx that referenced this pull request Sep 5, 2023
### Description

Remove deprecated functions in schema.h that are marked for deletion in
1.15

Signed-off-by: Justin Chu <justinchu@microsoft.com>
Signed-off-by: Corwin Joy <corwinjoy@gmail.com>
corwinjoy pushed a commit to corwinjoy/onnx that referenced this pull request Sep 5, 2023
### Description

Remove deprecated functions in schema.h that are marked for deletion in
1.15

Signed-off-by: Justin Chu <justinchu@microsoft.com>
Signed-off-by: Corwin Joy <corwinjoy@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
review needed: operators approvers Require reviews from members of operators-approvers schema Issues related to operator schemas
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants