Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use docconvert to normalize docstring to Google style #5580

Merged
merged 10 commits into from Nov 15, 2023
Merged

Use docconvert to normalize docstring to Google style #5580

merged 10 commits into from Nov 15, 2023

Conversation

justinchuby
Copy link
Contributor

@justinchuby justinchuby commented Sep 11, 2023 •
edited

Description

Use docconvert to normalize docstring to Google style and enable pydocstyle checks in ruff.

Motivation and Context

Standardize docstring style.

@justinchuby
Use docconvert to normalize docstring to Google style
b6b12a2 
Signed-off-by: Justin Chu <justinchu@microsoft.com>
@justinchuby
Manual fix
bd13f51 
Signed-off-by: Justin Chu <justinchu@microsoft.com>
@justinchuby justinchuby requested review from a team as code owners September 11, 2023 15:58
@justinchuby justinchuby marked this pull request as draft September 11, 2023 16:00
@codecov Codecov
Copy link

codecov bot commented Nov 14, 2023 •
edited

Codecov Report

Attention: 396 lines in your changes are missing coverage. Please review.

Comparison is base (ede2c77) 56.06% compared to head (62b921c) 56.06%.

Files Patch % Lines
onnx/backend/test/case/node/averagepool.py 0.00% 178 Missing ⚠️
onnx/backend/test/case/node/lppool.py 0.00% 115 Missing ⚠️
onnx/backend/test/case/node/affinegrid.py 0.00% 77 Missing ⚠️
onnx/reference/ops/op_pool_common.py 77.14% 18 Missing and 6 partials ⚠️
onnx/reference/ops/op_average_pool.py 84.61% 2 Missing ⚠️
Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #5580   +/-   ##
=======================================
  Coverage   56.06%   56.06%           
=======================================
  Files         501      501           
  Lines       29366    29366           
  Branches     4404     4404           
=======================================
  Hits        16463    16463           
  Misses      12091    12091           
  Partials      812      812

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@justinchuby
Format
68cc24d 
Signed-off-by: Justin Chu <justinchu@microsoft.com>
@justinchuby
Enable ruff and fix
ed4f2b5 
Signed-off-by: Justin Chu <justinchu@microsoft.com>
@justinchuby
Format
a751da6 
Signed-off-by: Justin Chu <justinchuby@users.noreply.github.com>
@justinchuby
Convert docstring
f9debcc 
Signed-off-by: Justin Chu <justinchuby@users.noreply.github.com>
@justinchuby
More fixes
c9d2c47 
Signed-off-by: Justin Chu <justinchuby@users.noreply.github.com>
@justinchuby justinchuby marked this pull request as ready for review November 14, 2023 23:20
@justinchuby justinchuby added code style Issues related to coding style or the linter better engineering Improve engineering quality of the project labels Nov 14, 2023
@justinchuby
Format
ea6b2da 
Signed-off-by: Justin Chu <justinchuby@users.noreply.github.com>
@justinchuby justinchuby added the auto update doc Generate md/proto files automatically using the CI pipeline label Nov 14, 2023
auto-merge was automatically disabled November 14, 2023 23:27

Pull request was closed

@justinchuby justinchuby reopened this Nov 14, 2023
@justinchuby @github-actions
CI:apply auto updated documentation/backend test data
62b921c 
Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@justinchuby justinchuby reopened this Nov 15, 2023
@justinchuby justinchuby removed the auto update doc Generate md/proto files automatically using the CI pipeline label Nov 15, 2023
@justinchuby justinchuby added this pull request to the merge queue Nov 15, 2023
Merged via the queue into onnx:main with commit a5f13c4 Nov 15, 2023
37 checks passed
@justinchuby justinchuby deleted the justinchu/google-doc branch November 15, 2023 01:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gramalingam gramalingam gramalingam approved these changes

Assignees
No one assigned
Labels
better engineering Improve engineering quality of the project code style Issues related to coding style or the linter
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@justinchuby @gramalingam