New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update diff bakend node tests for auto update doc #5604
Conversation
Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Potentially we should just update everything in CI because the CI machines are the most stable, compared to machines developers use?
We have discussed this a lot in our offline meetings, but I think there are some concerns to make the update only happen in the CI. Let me conclude:
Also we have another option to remove Operators.md entirely: #5571. For now, I think making "auto update doc" update docs/backend test data is a fine temporary solution. PR authors can decide to update them from their own, or simply reply on the CI to update for them. Going forward we can discuss further and see whether we can eventually make these updates all happen in the CI. |
Agree with all of the above. I meant we didn’t have to find the —diff and update. We can update all node tests (when ppl choose to use the auto gen label) |
Signed-off-by: Justin Chu <justinchuby@users.noreply.github.com>
In that way some of irrelevant files (input.pb or output.pb) might be updated unintentionally, because NumPy behaves differently on different platforms. The CI is running on Linux and for those old data created from Windows will be changed in the CI. I think using "--diff" in CI makes more sense to let the generation tool only update those corresponding test data. |
Two points. (i) Extending the utility with the --diff option is a good thing, it will help even devs who want to do it locally for their own validation. (ii) Whether the CI should use that option or not is orthogonal. I am fine with using the --diff. (Ideally it should make no difference.) |
Description
onnx/backend/test/cmd_tools.py
with a new option: "diff", which will only update the backend node test data whose script has been updated.auto_update_doc.yml
CI utilize "--diff" and update the backend node test data accordingly.Motivation and Context
#5450 "auto update doc" was introduced for helping users update docs like Operators.md and TestCoverage.md. It will be also useful that the CI can help users update backend node test as well.