New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove global counters in tests #5661
Remove global counters in tests #5661
Conversation
Signed-off-by: Justin Chu <justinchu@microsoft.com>
35d95ce
to
6b873e5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess the original test stats will be covered by the new codecov: #5660 instead?
Need to test the notebooks separately because they are not parallelizable. |
OK we need --dist loadscope |
Signed-off-by: Justin Chu <justinchuby@users.noreply.github.com>
Codecov ReportAll modified lines are covered by tests ✅
📢 Thoughts on this report? Let us know!. |
cc @xadupre |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for pytest -n auto --dist loadscope
, but I am surprise that the CI running time seems similar.
The Python tests don’t take much time so we may not see a big difference. Nevertheless enabling parallel testing allows us to catch undesirable order dependencies or global state dependencies in our tests |
Signed-off-by: Justin Chu <justinchuby@users.noreply.github.com>
6565d63
to
13e8b6f
Compare
Signed-off-by: Justin Chu <justinchuby@users.noreply.github.com>
Signed-off-by: Justin Chu <justinchuby@users.noreply.github.com>
Signed-off-by: Justin Chu <justinchuby@users.noreply.github.com>
Remove global counters in tests from reference_evaluator_backend_test and automatic_upgrade_test to allow parallel test execution.
Run tests in parallel in CI.