Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update diff2html to support dark theme when showing operator differences #5795

Merged
merged 1 commit into from Dec 8, 2023

Conversation

xadupre
Copy link
Contributor

@xadupre xadupre commented Dec 7, 2023

Description

The page showing differences between two operators is not readable in dark mode. diff2html was recently updated to fix this issue.

Signed-off-by: Xavier Dupre <xadupre@microsoft.com>
Copy link

codecov bot commented Dec 7, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (b59739b) 56.34% compared to head (410f564) 56.34%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5795   +/-   ##
=======================================
  Coverage   56.34%   56.34%           
=======================================
  Files         503      503           
  Lines       29626    29626           
  Branches     4438     4438           
=======================================
  Hits        16692    16692           
  Misses      12119    12119           
  Partials      815      815           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@xadupre xadupre marked this pull request as ready for review December 8, 2023 09:09
@xadupre xadupre requested a review from a team as a code owner December 8, 2023 09:09
@justinchuby justinchuby added this pull request to the merge queue Dec 8, 2023
Merged via the queue into onnx:main with commit 872f320 Dec 8, 2023
35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants