Fix reference implementation for nested local functions #5817
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Xavier Dupre <xadupre@microsoft.com>
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #5817 +/- ##
==========================================
+ Coverage 56.36% 56.39% +0.02%
==========================================
Files 503 503
Lines 29594 29620 +26
Branches 4424 4426 +2
==========================================
+ Hits 16682 16704 +22
- Misses 12107 12109 +2
- Partials 805 807 +2 ☔ View full report in Codecov by Sentry. |
justinchuby
reviewed
Dec 22, 2023
justinchuby
approved these changes
Dec 22, 2023
justinchuby
added
reference implementation
review needed: operators approvers
gramalingam
reviewed
Jan 3, 2024
gramalingam
approved these changes
Jan 3, 2024
Signed-off-by: Xavier Dupre <xadupre@microsoft.com>
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jan 3, 2024
Addresses issue mentioned in #5817 The inliner was not processing subgraphs for inlining. --------- Signed-off-by: Ganesan Ramalingam <grama@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Propagation model local functions to subgraphs.
Motivation and Context
ReferenceEvaluator fails at calling a local function from a subgraph in a local functions.