Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add valueinfos field to FunctionProto #5903

Merged
merged 7 commits into from Feb 6, 2024

Conversation

gramalingam
Copy link
Contributor

Description

  • Extend FunctionProto by adding a field to store ValueInfos for variables in the function.
  • Extend the helper function and parser to support this.

Motivation and Context

This enables type/shape information to be stored for variables in a FunctionProto, just like in a GraphProto. Note that this is optional, just like in a graph. This field may store type/shape info for the inputs and outputs of a function as well. (Note that, unlike in a graph, the input/output field in a FunctionProto do not have explicit types/shapes, they are just strings, not ValueInfo.)

Signed-off-by: Ganesan Ramalingam <grama@microsoft.com>
Signed-off-by: Ganesan Ramalingam <grama@microsoft.com>
@gramalingam gramalingam requested a review from a team as a code owner February 2, 2024 18:05
@gramalingam gramalingam added this to the 1.16 milestone Feb 2, 2024
Signed-off-by: Ganesan Ramalingam <grama@microsoft.com>
docs/IR.md Show resolved Hide resolved
onnx/defs/parser.cc Fixed Show fixed Hide fixed
Copy link

codecov bot commented Feb 2, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (3d976ff) 56.65% compared to head (98e9392) 56.65%.

Files Patch % Lines
onnx/helper.py 66.66% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5903   +/-   ##
=======================================
  Coverage   56.65%   56.65%           
=======================================
  Files         506      506           
  Lines       30193    30196    +3     
  Branches     4555     4556    +1     
=======================================
+ Hits        17105    17107    +2     
  Misses      12266    12266           
- Partials      822      823    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Ganesan Ramalingam <grama@microsoft.com>
Signed-off-by: Ganesan Ramalingam <grama@microsoft.com>
@gramalingam gramalingam added this pull request to the merge queue Feb 6, 2024
Merged via the queue into onnx:main with commit ffaa707 Feb 6, 2024
41 checks passed
@gramalingam gramalingam deleted the fun-value-infos branch February 6, 2024 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants