New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support register custom OpSchema by python #5906
Conversation
Why |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5906 +/- ##
==========================================
+ Coverage 56.68% 56.79% +0.11%
==========================================
Files 506 506
Lines 30231 30308 +77
Branches 4566 4580 +14
==========================================
+ Hits 17137 17214 +77
+ Misses 12268 12267 -1
- Partials 826 827 +1 ☔ View full report in Codecov by Sentry. |
You're right,
This is a good suggestion. I plan to implement this in the upcoming commit. This is my first time submitting a PR. I'll do my best to learn and get better at this! 😃 |
Signed-off-by: oPluss <opluss@qq.com>
Could you follow https://github.com/onnx/onnx/blob/main/CONTRIBUTING.md#coding-style to fix lint errors reported in https://github.com/onnx/onnx/actions/runs/7783887025/job/21232428145?pr=5906 ? Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your contribution! This is much needed.
Signed-off-by: oPluss <opluss@qq.com>
Signed-off-by: oPluss <opluss@qq.com>
Signed-off-by: oPluss <opluss@qq.com>
Signed-off-by: oPluss <opluss@qq.com>
Signed-off-by: oPluss <opluss@qq.com>
Signed-off-by: oPluss <opluss@qq.com>
Signed-off-by: opluss <opluss@qq.com>
Signed-off-by: opluss <opluss@qq.com>
Signed-off-by: opluss <opluss@qq.com>
This reverts commit f2577b9. Signed-off-by: opluss <opluss@qq.com>
Signed-off-by: opluss <opluss@qq.com>
Signed-off-by: opluss <opluss@qq.com>
LGTM ... the one question is whether to include it or not in the upcoming release, which has a deadline next weekend or so. Any opinions/thoughts welcome. |
I think it would be beneficial to include this which will allow us to do further validation on models. If anything comes up we can always revert the PR and stage it for the next release. That said, I don't have a strong opinion |
Use `move` instead of `forward` Remove default domain value in `DeregisterSchema` Signed-off-by: opluss <opluss@qq.com>
@OYCN : can you please take a look at the merge conflicts? We can try to merge this PR in this week, ahead of the next release cutoff. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Merge conflicts to be resolved, LGTM otherwise.
Signed-off-by: oPluss <opluss@qq.com>
The merge conflicts have been resolved. But some Windows-CI failing during the CMake configuration process. This might be due to an external problem? |
Description
OpSchema::Finalize
multiple timesonnx.defs.has
with version parameterexample for register OpSchema:
example for deregister OpSchema:
Motivation and Context
Follow up of #5019