Remove deprecated properties from FormalParameter #5921
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Justin Chu <justinchu@microsoft.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5921 +/- ##
=======================================
Coverage 56.65% 56.65%
=======================================
Files 506 506
Lines 30194 30194
Branches 4556 4556
=======================================
Hits 17105 17105
Misses 12266 12266
Partials 823 823 ☔ View full report in Codecov by Sentry. |
There is not. The tests were previously updated at deprecation. |
jcwchen
approved these changes
Feb 9, 2024
andife
pushed a commit
to andife/onnx
that referenced
this pull request
Feb 9, 2024
### Description Remove deprecated properties from FormalParameter. ### Motivation and Context The properties are set to be removed for the 1.16 release. Fixes onnx#5074 Signed-off-by: Justin Chu <justinchu@microsoft.com> Signed-off-by: Andreas Fehlner <fehlner@arcor.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Remove deprecated properties from FormalParameter.
Motivation and Context
The properties are set to be removed for the 1.16 release. Fixes #5074