-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(ci): install python dependencies with --only-binary :all:
in manylinux
#6120
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6120 +/- ##
==========================================
+ Coverage 56.95% 57.04% +0.08%
==========================================
Files 506 506
Lines 30467 30935 +468
Branches 4592 4592
==========================================
+ Hits 17353 17646 +293
- Misses 12285 12463 +178
+ Partials 829 826 -3 ☔ View full report in Codecov by Sentry. |
…nylinux Signed-off-by: mayeut <mayeut@users.noreply.github.com>
@justinchuby, I'm not sure yet the failure on python 3.12 aarch64 are related to the changes here. I won't have time to look into this before the end of next week I think. |
We can fix LinuxRelease_aarch64 in a separate PR |
@justinchuby, the failures on python 3.12 seem to be coming from this PR. The set of dependencies changes more than expected. |
…nylinux (onnx#6120) ### Description Only install python dependencies from wheels in manylinux. ### Motivation and Context The latest version of google-re2 dropped support for manylinux2014. google-re2 fails to build from sources thus failing the Linux release pipelines. This PR forces installation from wheels on manylinux which thus fallback on the latest version of google-re2 with a wheel for manylinux2014. Another solution would be to bump the manylinux images to manylinux_2_28 but that could have impact on downstream users (e.g. impossible to install wheel from rh7, amazon linux 2, ubuntu 18.04). Signed-off-by: mayeut <mayeut@users.noreply.github.com> Co-authored-by: Justin Chu <justinchuby@users.noreply.github.com> Signed-off-by: isdanni <leedanni@gmail.com>
### Description Only install google-re2 from wheels. ### Motivation and Context The latest version of google-re2 dropped support for manylinux2014. google-re2 fails to build from sources thus failing the Linux release pipelines. This PR forces installation from wheels on manylinux which thus fallback on the latest version of google-re2 with a wheel for manylinux2014. It reverts #6120 which forced all dependencies to be available as wheels (psutil is not which forbids installing recent versions of jupyter/ipykernel). Another solution would be to bump the manylinux images to manylinux_2_28 but that could have impact on downstream users (e.g. impossible to install wheel from rh7, amazon linux 2, ubuntu 18.04). Signed-off-by: mayeut <mayeut@users.noreply.github.com>
…nylinux (#6120) ### Description Only install python dependencies from wheels in manylinux. ### Motivation and Context The latest version of google-re2 dropped support for manylinux2014. google-re2 fails to build from sources thus failing the Linux release pipelines. This PR forces installation from wheels on manylinux which thus fallback on the latest version of google-re2 with a wheel for manylinux2014. Another solution would be to bump the manylinux images to manylinux_2_28 but that could have impact on downstream users (e.g. impossible to install wheel from rh7, amazon linux 2, ubuntu 18.04). Signed-off-by: mayeut <mayeut@users.noreply.github.com> Co-authored-by: Justin Chu <justinchuby@users.noreply.github.com> (cherry picked from commit 9f6f3a0)
### Description Only install google-re2 from wheels. ### Motivation and Context The latest version of google-re2 dropped support for manylinux2014. google-re2 fails to build from sources thus failing the Linux release pipelines. This PR forces installation from wheels on manylinux which thus fallback on the latest version of google-re2 with a wheel for manylinux2014. It reverts #6120 which forced all dependencies to be available as wheels (psutil is not which forbids installing recent versions of jupyter/ipykernel). Another solution would be to bump the manylinux images to manylinux_2_28 but that could have impact on downstream users (e.g. impossible to install wheel from rh7, amazon linux 2, ubuntu 18.04). Signed-off-by: mayeut <mayeut@users.noreply.github.com> (cherry picked from commit aa2cdac)
…nylinux (#6120) ### Description Only install python dependencies from wheels in manylinux. ### Motivation and Context The latest version of google-re2 dropped support for manylinux2014. google-re2 fails to build from sources thus failing the Linux release pipelines. This PR forces installation from wheels on manylinux which thus fallback on the latest version of google-re2 with a wheel for manylinux2014. Another solution would be to bump the manylinux images to manylinux_2_28 but that could have impact on downstream users (e.g. impossible to install wheel from rh7, amazon linux 2, ubuntu 18.04). Signed-off-by: Matthieu Darbois <mayeut@users.noreply.github.com> Co-authored-by: Justin Chu <justinchuby@users.noreply.github.com> (cherry picked from commit 9f6f3a0)
### Description Only install google-re2 from wheels. ### Motivation and Context The latest version of google-re2 dropped support for manylinux2014. google-re2 fails to build from sources thus failing the Linux release pipelines. This PR forces installation from wheels on manylinux which thus fallback on the latest version of google-re2 with a wheel for manylinux2014. It reverts #6120 which forced all dependencies to be available as wheels (psutil is not which forbids installing recent versions of jupyter/ipykernel). Another solution would be to bump the manylinux images to manylinux_2_28 but that could have impact on downstream users (e.g. impossible to install wheel from rh7, amazon linux 2, ubuntu 18.04). Signed-off-by: Matthieu Darbois <mayeut@users.noreply.github.com> (cherry picked from commit aa2cdac)
…nylinux (#6120) ### Description Only install python dependencies from wheels in manylinux. ### Motivation and Context The latest version of google-re2 dropped support for manylinux2014. google-re2 fails to build from sources thus failing the Linux release pipelines. This PR forces installation from wheels on manylinux which thus fallback on the latest version of google-re2 with a wheel for manylinux2014. Another solution would be to bump the manylinux images to manylinux_2_28 but that could have impact on downstream users (e.g. impossible to install wheel from rh7, amazon linux 2, ubuntu 18.04). Signed-off-by: Matthieu Darbois <mayeut@users.noreply.github.com> Co-authored-by: Justin Chu <justinchuby@users.noreply.github.com> (cherry picked from commit 9f6f3a0)
### Description Only install google-re2 from wheels. ### Motivation and Context The latest version of google-re2 dropped support for manylinux2014. google-re2 fails to build from sources thus failing the Linux release pipelines. This PR forces installation from wheels on manylinux which thus fallback on the latest version of google-re2 with a wheel for manylinux2014. It reverts #6120 which forced all dependencies to be available as wheels (psutil is not which forbids installing recent versions of jupyter/ipykernel). Another solution would be to bump the manylinux images to manylinux_2_28 but that could have impact on downstream users (e.g. impossible to install wheel from rh7, amazon linux 2, ubuntu 18.04). Signed-off-by: Matthieu Darbois <mayeut@users.noreply.github.com> (cherry picked from commit aa2cdac)
…nylinux (onnx#6120) ### Description Only install python dependencies from wheels in manylinux. ### Motivation and Context The latest version of google-re2 dropped support for manylinux2014. google-re2 fails to build from sources thus failing the Linux release pipelines. This PR forces installation from wheels on manylinux which thus fallback on the latest version of google-re2 with a wheel for manylinux2014. Another solution would be to bump the manylinux images to manylinux_2_28 but that could have impact on downstream users (e.g. impossible to install wheel from rh7, amazon linux 2, ubuntu 18.04). Signed-off-by: mayeut <mayeut@users.noreply.github.com> Co-authored-by: Justin Chu <justinchuby@users.noreply.github.com> Signed-off-by: Ganesan Ramalingam <grama@microsoft.com>
### Description Only install google-re2 from wheels. ### Motivation and Context The latest version of google-re2 dropped support for manylinux2014. google-re2 fails to build from sources thus failing the Linux release pipelines. This PR forces installation from wheels on manylinux which thus fallback on the latest version of google-re2 with a wheel for manylinux2014. It reverts onnx#6120 which forced all dependencies to be available as wheels (psutil is not which forbids installing recent versions of jupyter/ipykernel). Another solution would be to bump the manylinux images to manylinux_2_28 but that could have impact on downstream users (e.g. impossible to install wheel from rh7, amazon linux 2, ubuntu 18.04). Signed-off-by: mayeut <mayeut@users.noreply.github.com> Signed-off-by: Ganesan Ramalingam <grama@microsoft.com>
Description
Only install python dependencies from wheels in manylinux.
Motivation and Context
The latest version of google-re2 dropped support for manylinux2014.
google-re2 fails to build from sources thus failing the Linux release pipelines.
This PR forces installation from wheels on manylinux which thus fallback on the latest version of google-re2 with a wheel for manylinux2014.
Another solution would be to bump the manylinux images to manylinux_2_28 but that could have impact on downstream users (e.g. impossible to install wheel from rh7, amazon linux 2, ubuntu 18.04).