Verify model deletion after testing #6127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ramakrishnan Sivakumar <ramkrishna2910@gmail.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6127 +/- ##
==========================================
+ Coverage 56.95% 57.04% +0.08%
==========================================
Files 506 506
Lines 30467 30935 +468
Branches 4592 4592
==========================================
+ Hits 17353 17646 +293
- Misses 12285 12464 +179
+ Partials 829 825 -4 ☔ View full report in Codecov by Sentry. |
justinchuby
approved these changes
May 3, 2024
|
Thanks! |
Signed-off-by: Ramakrishnan Sivakumar <ramkrishna2910@gmail.com>
|
@justinchuby using a temp file did not help as the cache folder was persistent until the context manager quit at the end of the test. That was still causing storage issues. |
|
I think it's possible to create a context for each model? But this looks good too |
isdanni
pushed a commit
to isdanni/onnx
that referenced
this pull request
May 6, 2024
### Description Deletes model downloaded to disk after testing to avoid storage issues. --------- Signed-off-by: Ramakrishnan Sivakumar <ramkrishna2910@gmail.com> Signed-off-by: isdanni <leedanni@gmail.com>
gramalingam
pushed a commit
to gramalingam/onnx
that referenced
this pull request
Jun 6, 2024
### Description Deletes model downloaded to disk after testing to avoid storage issues. --------- Signed-off-by: Ramakrishnan Sivakumar <ramkrishna2910@gmail.com> Signed-off-by: Ganesan Ramalingam <grama@microsoft.com>
andife
pushed a commit
to andife/onnx
that referenced
this pull request
Jul 20, 2024
### Description Deletes model downloaded to disk after testing to avoid storage issues. --------- Signed-off-by: Ramakrishnan Sivakumar <ramkrishna2910@gmail.com> Signed-off-by: Andreas Fehlner <fehlner@arcor.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Deletes model downloaded to disk after testing to avoid storage issues.